Skip to content

Commit e554d33

Browse files
Yuhtafacebook-github-bot
authored andcommitted
fix: Hanging MultiFragmentTest.maxBytes (facebookincubator#13743)
Summary: Pull Request resolved: facebookincubator#13743 `MultiFragmentTest.maxBytes` is hanging after folly random number generator update (due to different `Destination::targetSizePct_`). This is because the sizes of the serialized data changed and the test enters into a deadlock state due to the setup in the test itself (not prod code). Unblock this by adjusting the data sizes. Reviewed By: bikramSingh91 Differential Revision: D76459943 fbshipit-source-id: 90557b9f99a78ebe24f97f580c5add6ff2e23157
1 parent 612e72a commit e554d33

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

velox/exec/tests/MultiFragmentTest.cpp

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2592,12 +2592,15 @@ DEBUG_ONLY_TEST_P(MultiFragmentTest, maxBytes) {
25922592
return;
25932593
}
25942594
std::string s(25, 'x');
2595-
// Keep the row count under 7000 to avoid hitting the row limit in the
2596-
// operator instead.
2595+
// This number is chosen so that serialization of all the 100 vectors can fit
2596+
// in 32MB (the QueryConfig::maxOutputBufferSize). Otherwise the driver is
2597+
// blocked, since the data consumed by DataFetcher is so small that the
2598+
// remaining buffered data is still larger than OutputBuffer::continueSize_.
2599+
constexpr int kNumRows = 4'800;
25972600
auto data = makeRowVector({
2598-
makeFlatVector<int64_t>(5'000, [](auto row) { return row; }),
2599-
makeFlatVector<int64_t>(5'000, [](auto row) { return row; }),
2600-
makeConstant(StringView(s), 5'000),
2601+
makeFlatVector<int64_t>(kNumRows, [](auto row) { return row; }),
2602+
makeFlatVector<int64_t>(kNumRows, [](auto row) { return row; }),
2603+
makeConstant(StringView(s), kNumRows),
26012604
});
26022605

26032606
core::PlanNodeId outputNodeId;

0 commit comments

Comments
 (0)