Skip to content

Commit 31bbb3a

Browse files
committed
refactor: replace placeholder type integers with PP_PLACEHOLDER_TYPE enum for improved readability
1 parent 67b7283 commit 31bbb3a

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

src/tppt/tool/ppt2template.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from typing import Any
99

1010
from pptx import Presentation as PptxPresentation
11+
from pptx.enum.shapes import PP_PLACEHOLDER_TYPE
1112

1213
import tppt
1314

@@ -162,40 +163,39 @@ def analyze_layout(layout: LayoutInfo) -> LayoutInfo:
162163

163164
# Determine base name based on placeholder type
164165
match ph_type:
165-
case 1: # Title
166+
case PP_PLACEHOLDER_TYPE.TITLE:
166167
base_name = "title"
167-
case 2: # Body/Content
168+
case PP_PLACEHOLDER_TYPE.BODY:
168169
if "content" in layout_name_lower or "text" in layout_name_lower:
169170
base_name = "content"
170171
else:
171172
base_name = "body"
172-
case 3: # CenteredTitle
173+
case PP_PLACEHOLDER_TYPE.CENTER_TITLE:
173174
base_name = "title"
174-
case 4: # Subtitle
175+
case PP_PLACEHOLDER_TYPE.SUBTITLE:
175176
base_name = "subtitle"
176-
case 7: # Chart
177+
case PP_PLACEHOLDER_TYPE.CHART:
177178
if "chart" in sample_ph.name.lower():
178179
base_name = "chart"
179180
else:
180181
base_name = "content"
181-
case 8: # Table
182+
case PP_PLACEHOLDER_TYPE.TABLE:
182183
base_name = "table"
183-
case 13: # SlideNumber
184+
case PP_PLACEHOLDER_TYPE.SLIDE_NUMBER:
184185
base_name = "slide_number"
185-
case 15: # Footer
186+
case PP_PLACEHOLDER_TYPE.FOOTER:
186187
base_name = "footer"
187-
case 16: # Date
188+
case PP_PLACEHOLDER_TYPE.DATE:
188189
base_name = "date"
189-
case 18: # Picture
190+
case PP_PLACEHOLDER_TYPE.PICTURE:
190191
base_name = "picture"
191-
case 19: # VerticalTitle
192+
case PP_PLACEHOLDER_TYPE.VERTICAL_TITLE:
192193
base_name = "vertical_title"
193-
case 20: # VerticalBody
194+
case PP_PLACEHOLDER_TYPE.VERTICAL_BODY:
194195
base_name = "vertical_text"
195196
case _:
196197
# For other types, use the cleaned placeholder name
197198
base_name = clean_field_name(sample_ph.name)
198-
199199
# Process all types of placeholders
200200
if ph_type not in [
201201
1,

0 commit comments

Comments
 (0)