Skip to content

Commit 4b52b43

Browse files
committed
refactor: adjust build method in SlideBuilder for better type handling
1 parent 776573d commit 4b52b43

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

src/tppt/pptx/presentation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def slide(
161161
slide_layout = slide_builder._slide_layout.to_pptx()
162162
new_slide = self._pptx.slides.add_slide(slide_layout)
163163

164-
slide_builder.build(new_slide)
164+
slide_builder.build(new_slide) # type: ignore
165165

166166
return self
167167

src/tppt/pptx/slide.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -151,11 +151,13 @@ def table(self, data: DataFrame, **kwargs: Unpack[TableProps]) -> Self:
151151
)
152152
return self
153153

154-
def build(self, slide: PptxSlide) -> Slide:
155-
tppt_slide = Slide(slide)
154+
if not TYPE_CHECKING:
156155

157-
self._placeholder_registry(tppt_slide)
158-
for register in self._shape_registry:
159-
register(tppt_slide)
156+
def build(self, slide: PptxSlide) -> Slide:
157+
tppt_slide = Slide(slide)
160158

161-
return tppt_slide
159+
self._placeholder_registry(tppt_slide)
160+
for register in self._shape_registry:
161+
register(tppt_slide)
162+
163+
return tppt_slide

0 commit comments

Comments
 (0)