Skip to content

Commit 400c5a7

Browse files
committed
Merge branch 'logo' into 'main'
fix: disabled logo function when SERVER_NAME is not set See merge request yaal/canaille!250
2 parents 8e55bed + f3b56fd commit 400c5a7

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

canaille/app/mails.py

+6-10
Original file line numberDiff line numberDiff line change
@@ -5,27 +5,23 @@
55
from email.utils import make_msgid
66

77
from flask import current_app
8-
from flask import request
98

109
from canaille.app import get_current_domain
1110
from canaille.app import get_current_mail_domain
1211

1312

1413
def logo():
1514
logo_url = current_app.config["CANAILLE"]["LOGO"]
16-
if not logo_url:
15+
if not logo_url or not current_app.config["SERVER_NAME"]:
1716
return None, None, None
1817

1918
logo_filename = logo_url.split("/")[-1]
2019
if not logo_url.startswith("http"):
21-
if current_app.config.get("SERVER_NAME"):
22-
logo_url = "{}://{}/{}".format(
23-
current_app.config.get("PREFERRED_URL_SCHEME"),
24-
get_current_domain(),
25-
logo_url,
26-
)
27-
else:
28-
logo_url = f"{request.url_root}{logo_url}"
20+
logo_url = "{}://{}/{}".format(
21+
current_app.config.get("PREFERRED_URL_SCHEME"),
22+
get_current_domain(),
23+
logo_url,
24+
)
2925

3026
try:
3127
with urllib.request.urlopen(logo_url) as f:

0 commit comments

Comments
 (0)