chore: add short-circuit in stavefile PrePushCheck for empty pushRefs

preminger · preminger · commit 62b4b1453c8d · 2025-12-07T10:29:46.000-05:00
diff --git a/stavefile.go b/stavefile.go
@@ -93,6 +93,7 @@ func Init() error { // stave:help=Install dev tools (Brewfile), setup hooks (res
 		return err
 	}
 
+	// Setup hooks.
 	if err := setupHooksStave(); err != nil {
 		return err
 	}
@@ -336,7 +337,11 @@ func PrePushCheck(remoteName, _remoteURL string) error { // stave:help=Run pre-p
 		return fmt.Errorf("failed to read push refs: %w", err)
 	}
 
-	// Check that changelog has changed on current branch
+	if len(pushRefs) == 0 {
+		slog.Warn("no refs pushed, skipping changelog pre-push check")
+		return nil
+	}
+
 	slog.Info("about to run changelog pre-push check", slog.String("remote_name", remoteName), slog.Any("push_refs", pushRefs))
 	result, err := changelog.PrePushCheck(changelog.PrePushCheckOptions{
 		RemoteName:    remoteName,

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,7 @@ func Init() error { // stave:help=Install dev tools (Brewfile), setup hooks (res`
`93`	`93`	`return err`
`94`	`94`	`}`
`95`	`95`
	`96`	`+ // Setup hooks.`
`96`	`97`	`if err := setupHooksStave(); err != nil {`
`97`	`98`	`return err`
`98`	`99`	`}`
`@@ -336,7 +337,11 @@ func PrePushCheck(remoteName, _remoteURL string) error { // stave:help=Run pre-p`
`336`	`337`	`return fmt.Errorf("failed to read push refs: %w", err)`
`337`	`338`	`}`
`338`	`339`
`339`		`- // Check that changelog has changed on current branch`
	`340`	`+ if len(pushRefs) == 0 {`
	`341`	`+ slog.Warn("no refs pushed, skipping changelog pre-push check")`
	`342`	`+ return nil`
	`343`	`+ }`
	`344`	`+`
`340`	`345`	`slog.Info("about to run changelog pre-push check", slog.String("remote_name", remoteName), slog.Any("push_refs", pushRefs))`
`341`	`346`	`result, err := changelog.PrePushCheck(changelog.PrePushCheckOptions{`
`342`	`347`	`RemoteName: remoteName,`