Skip to content

Commit b4fae65

Browse files
committed
refactor: remove logger usage and replace with console methods in app-bridge and auth-callback
1 parent 2954fee commit b4fae65

3 files changed

Lines changed: 5 additions & 18 deletions

File tree

src/runtime/logger.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/runtime/plugins/app-bridge.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { defineNuxtPlugin } from '#app'
22
import type { ShopifyGlobal } from '@shopify/app-bridge-types'
3-
import { logger } from '../logger'
43

54
declare global {
65
interface Window {
@@ -21,9 +20,7 @@ export default defineNuxtPlugin(() => {
2120
const bridge = new Proxy({} as ShopifyGlobal, {
2221
get(_target, prop, receiver) {
2322
if (!window.shopify) {
24-
logger.warn({
25-
message: 'window.shopify is not available yet. The CDN script may not have loaded.'
26-
})
23+
console.warn('window.shopify is not available yet. The CDN script may not have loaded.')
2724
throw new Error(
2825
'Shopify App Bridge is not available. Ensure the app is loaded inside the Shopify Admin.'
2926
)

src/runtime/server/routes/auth-callback.ts

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import {
55
getSessionStorage
66
} from '../services/shopify'
77
import { createAdminApiContext } from '../utils/clients'
8-
import { logger } from '../../logger'
98

109
/**
1110
* Handle the OAuth callback from Shopify.
@@ -19,8 +18,8 @@ export default defineEventHandler(async (event) => {
1918

2019
try {
2120
const callbackResponse = await api.auth.callback({
22-
rawRequest: event.req,
23-
rawResponse: event.res
21+
rawRequest: event.node.req,
22+
rawResponse: event.node.res
2423
})
2524

2625
const { session } = callbackResponse
@@ -44,10 +43,7 @@ export default defineEventHandler(async (event) => {
4443
try {
4544
await api.webhooks.register({ session })
4645
} catch (e) {
47-
logger.debug({
48-
message: '[shopify-app-nuxt] Failed to register webhooks:',
49-
error: e,
50-
})
46+
console.debug('[shopify-app-nuxt] Failed to register webhooks:', e)
5147
}
5248
}
5349

@@ -60,10 +56,7 @@ export default defineEventHandler(async (event) => {
6056
const redirectUrl = `${config.appUrl}?shop=${shop}&host=${host}`
6157
return sendRedirect(event, redirectUrl, 302)
6258
} catch (error: any) {
63-
logger.debug({
64-
message: '[shopify-app-nuxt] Auth callback error:',
65-
error: error.message,
66-
})
59+
console.debug('[shopify-app-nuxt] Auth callback error:', error)
6760
throw createError({
6861
statusCode: 500,
6962
statusMessage: 'Authentication failed',

0 commit comments

Comments
 (0)