linting

Author: yannh

pkg/registry/registry.go

@@ -80,7 +80,7 @@ func New(schemaLocation string, strict bool, skipTLS bool) (Registry, error) {
 
 	if strings.HasPrefix(schemaLocation, "http") {
 		return newHTTPRegistry(schemaLocation, strict, skipTLS), nil
-	} else {
-		return newLocalRegistry(schemaLocation, strict), nil
 	}
+
+	return newLocalRegistry(schemaLocation, strict), nil
 }

pkg/resource/stream.go

@@ -7,7 +7,10 @@ import (
 	"io"
 )
 
-// Thank you https://github.com/helm/helm-classic/blob/master/codec/yaml.go#L90
+// SplitYAMLDocument is a bufio.SplitFunc for splitting a YAML document into individual documents.
+//
+// This is from Kubernetes' 'pkg/util/yaml'.splitYAMLDocument, which is unfortunately
+// not exported.
 func SplitYAMLDocument(data []byte, atEOF bool) (advance int, token []byte, err error) {
 	const yamlSeparator = "\n---"
 	if atEOF && len(data) == 0 {

pkg/validator/validator.go

@@ -157,9 +157,9 @@ func (val *v) ValidateResource(res resource.Resource) Result {
 	if schema == nil {
 		if val.opts.IgnoreMissingSchemas {
 			return Result{Resource: res, Err: nil, Status: Skipped}
-		} else {
-			return Result{Resource: res, Err: fmt.Errorf("could not find schema for %s", sig.Kind), Status: Error}
 		}
+
+		return Result{Resource: res, Err: fmt.Errorf("could not find schema for %s", sig.Kind), Status: Error}
 	}
 
 	resourceLoader := gojsonschema.NewGoLoader(r)