Skip to content

Commit 52875c5

Browse files
minororange杨辰卓
andauthored
style: 代码风格调整优化 (#34)
* feat: 增加泛型注释,方便识别 * fix: csfix & phpstan * fix: csfix 最新版本格式化 --------- Co-authored-by: 杨辰卓 <yangchenzhuo@westmoon.com>
1 parent 66c70ef commit 52875c5

File tree

7 files changed

+30
-20
lines changed

7 files changed

+30
-20
lines changed

src/Artful.php

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ class Artful
4747
HttpServiceProvider::class,
4848
];
4949

50-
private static null|Closure|ContainerInterface $container = null;
50+
private static Closure|ContainerInterface|null $container = null;
5151

5252
/**
5353
* @throws ContainerException
5454
*/
55-
private function __construct(array $config, null|Closure|ContainerInterface $container = null)
55+
private function __construct(array $config, Closure|ContainerInterface|null $container = null)
5656
{
5757
$this->registerServices($config, $container);
5858

@@ -61,7 +61,11 @@ private function __construct(array $config, null|Closure|ContainerInterface $con
6161
}
6262

6363
/**
64-
* @return mixed
64+
* @template T
65+
*
66+
* @param class-string<T> $service
67+
*
68+
* @return mixed|T
6569
*
6670
* @throws ContainerException
6771
* @throws ServiceNotFoundException
@@ -78,7 +82,7 @@ public static function __callStatic(string $service, array $config)
7882
/**
7983
* @throws ContainerException
8084
*/
81-
public static function config(array $config = [], null|Closure|ContainerInterface $container = null): bool
85+
public static function config(array $config = [], Closure|ContainerInterface|null $container = null): bool
8286
{
8387
if (self::hasContainer() && !($config['_force'] ?? false)) {
8488
return false;
@@ -144,6 +148,12 @@ public static function make(string $service, array $parameters = []): mixed
144148
}
145149

146150
/**
151+
* @template T
152+
*
153+
* @param class-string<T> $service
154+
*
155+
* @return mixed|T
156+
*
147157
* @throws ServiceNotFoundException
148158
* @throws ContainerException
149159
*/
@@ -168,7 +178,7 @@ public static function has(string $service): bool
168178
return Artful::getContainer()->has($service);
169179
}
170180

171-
public static function setContainer(null|Closure|ContainerInterface $container): void
181+
public static function setContainer(Closure|ContainerInterface|null $container): void
172182
{
173183
self::$container = $container;
174184
}
@@ -224,7 +234,7 @@ public static function registerService(string $service, mixed $data = null): voi
224234
* @throws InvalidParamsException
225235
* @throws ServiceNotFoundException
226236
*/
227-
public static function shortcut(string $shortcut, array $params = []): null|Collection|MessageInterface|Rocket
237+
public static function shortcut(string $shortcut, array $params = []): Collection|MessageInterface|Rocket|null
228238
{
229239
if (!class_exists($shortcut) || !in_array(ShortcutInterface::class, class_implements($shortcut))) {
230240
throw new InvalidParamsException(Exception::PARAMS_SHORTCUT_INVALID, "参数异常: [{$shortcut}] 未实现 `ShortcutInterface`");
@@ -240,7 +250,7 @@ public static function shortcut(string $shortcut, array $params = []): null|Coll
240250
* @throws ContainerException
241251
* @throws InvalidParamsException
242252
*/
243-
public static function artful(array $plugins, array $params): null|Collection|MessageInterface|Rocket
253+
public static function artful(array $plugins, array $params): Collection|MessageInterface|Rocket|null
244254
{
245255
Event::dispatch(new Event\ArtfulStart($plugins, $params));
246256

@@ -333,7 +343,7 @@ protected static function verifyPlugin(array $plugins): void
333343
/**
334344
* @throws ContainerException
335345
*/
336-
private function registerServices(array $config, null|Closure|ContainerInterface $container = null): void
346+
private function registerServices(array $config, Closure|ContainerInterface|null $container = null): void
337347
{
338348
foreach ($this->coreService as $service) {
339349
self::registerService($service, ContainerServiceProvider::class == $service ? $container : $config);

src/Contract/PackerInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
interface PackerInterface
1010
{
11-
public function pack(null|array|Collection $payload, ?array $params = null): string;
11+
public function pack(array|Collection|null $payload, ?array $params = null): string;
1212

1313
public function unpack(string $payload, ?array $params = null): ?array;
1414
}

src/Functions.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ function get_packer(mixed $packer): PackerInterface
5959
return $packer;
6060
}
6161

62-
function filter_params(null|array|Collection $params, ?Closure $closure = null): Collection
62+
function filter_params(array|Collection|null $params, ?Closure $closure = null): Collection
6363
{
6464
$params = Collection::wrap($params);
6565

src/Packer/JsonPacker.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
class JsonPacker implements PackerInterface
1212
{
13-
public function pack(null|array|Collection $payload, ?array $params = null): string
13+
public function pack(array|Collection|null $payload, ?array $params = null): string
1414
{
1515
if (($payload instanceof Collection && $payload->isEmpty()) || empty($payload)) {
1616
return '';

src/Packer/QueryPacker.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
class QueryPacker implements PackerInterface
1212
{
13-
public function pack(null|array|Collection $payload, ?array $params = null): string
13+
public function pack(array|Collection|null $payload, ?array $params = null): string
1414
{
1515
return Collection::wrap($payload)->query();
1616
}

src/Packer/XmlPacker.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
class XmlPacker implements PackerInterface
1212
{
13-
public function pack(null|array|Collection $payload, ?array $params = null): string
13+
public function pack(array|Collection|null $payload, ?array $params = null): string
1414
{
1515
return Collection::wrap($payload)->toXml();
1616
}

src/Rocket.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ class Rocket implements JsonSerializableInterface, ArrayAccess
3232

3333
private string $direction = DirectionInterface::class;
3434

35-
private null|Collection|MessageInterface $destination = null;
35+
private Collection|MessageInterface|null $destination = null;
3636

37-
private null|RequestInterface|ResponseInterface $destinationOrigin = null;
37+
private RequestInterface|ResponseInterface|null $destinationOrigin = null;
3838

3939
public function getRadar(): ?RequestInterface
4040
{
@@ -72,7 +72,7 @@ public function getPayload(): ?Collection
7272
return $this->payload;
7373
}
7474

75-
public function setPayload(null|array|Collection $payload): Rocket
75+
public function setPayload(array|Collection|null $payload): Rocket
7676
{
7777
if (is_array($payload)) {
7878
$payload = new Collection($payload);
@@ -129,24 +129,24 @@ public function setDirection(string $direction): Rocket
129129
return $this;
130130
}
131131

132-
public function getDestination(): null|Collection|MessageInterface
132+
public function getDestination(): Collection|MessageInterface|null
133133
{
134134
return $this->destination;
135135
}
136136

137-
public function setDestination(null|Collection|MessageInterface $destination): Rocket
137+
public function setDestination(Collection|MessageInterface|null $destination): Rocket
138138
{
139139
$this->destination = $destination;
140140

141141
return $this;
142142
}
143143

144-
public function getDestinationOrigin(): null|RequestInterface|ResponseInterface
144+
public function getDestinationOrigin(): RequestInterface|ResponseInterface|null
145145
{
146146
return $this->destinationOrigin;
147147
}
148148

149-
public function setDestinationOrigin(null|RequestInterface|ResponseInterface $destinationOrigin): Rocket
149+
public function setDestinationOrigin(RequestInterface|ResponseInterface|null $destinationOrigin): Rocket
150150
{
151151
$this->destinationOrigin = $destinationOrigin;
152152

0 commit comments

Comments
 (0)