Skip to content

Commit 1766146

Browse files
committed
Revert "[http2] Stabilize rst_stream experiment"
This reverts commit aef71dc.
1 parent aef71dc commit 1766146

File tree

6 files changed

+39
-1
lines changed

6 files changed

+39
-1
lines changed

bazel/experiments.bzl

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/core/ext/transport/chttp2/transport/chttp2_transport.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2439,7 +2439,8 @@ void grpc_chttp2_cancel_stream(grpc_chttp2_transport* t, grpc_chttp2_stream* s,
24392439
// sent headers yet (still in "idle" state). Note that since we have
24402440
// marked the stream closed above, we won't be writing to it
24412441
// anymore.
2442-
if (t->is_client && !sent_initial_metadata) {
2442+
if (grpc_core::IsRstStreamFixEnabled() && t->is_client &&
2443+
!sent_initial_metadata) {
24432444
return;
24442445
}
24452446
grpc_chttp2_add_rst_stream_to_next_write(

src/core/lib/experiments/experiments.cc

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/core/lib/experiments/experiments.h

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/core/lib/experiments/experiments.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,11 @@
222222
expiry: 2025/06/06
223223
224224
test_tags: []
225+
- name: rst_stream_fix
226+
description: Fix for RST_STREAM - do not send for idle streams (https://github.com/grpc/grpc/issues/38758)
227+
expiry: 2025/06/06
228+
229+
test_tags: []
225230
- name: schedule_cancellation_over_write
226231
description: Allow cancellation op to be scheduled over a write
227232
expiry: 2025/10/01

src/core/lib/experiments/rollouts.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@
8282
default: false
8383
- name: promise_based_http2_server_transport
8484
default: false
85+
- name: rst_stream_fix
86+
default: true
8587
- name: schedule_cancellation_over_write
8688
default: false
8789
- name: server_global_callbacks_ownership

0 commit comments

Comments
 (0)