Fixes

Author: yashykt

src/core/ext/transport/chaotic_good/data_endpoints.cc

@@ -491,14 +491,14 @@ auto Endpoint::WriteLoop(uint32_t id,
                output_buffers = std::move(output_buffers),
                requested_metrics = std::move(requested_metrics),
                data_rate_metric, ztrace_collector,
-               telemetry_info = std::move(telemetry_info)]() {
+               telemetry_info = std::move(telemetry_info)]() mutable {
     return TrySeq(
         output_buffers->Next(id),
         [endpoint, id,
          requested_metrics = absl::Span<const size_t>(requested_metrics),
          data_rate_metric, output_buffers, ztrace_collector,
          telemetry_info = std::move(telemetry_info)](
-            data_endpoints_detail::NextWrite next_write) {
+            data_endpoints_detail::NextWrite next_write) mutable {
           GRPC_TRACE_LOG(chaotic_good, INFO)
               << "CHAOTIC_GOOD: " << output_buffers.get() << " "
               << ResolvedAddressToString(endpoint->GetPeerAddress())
@@ -519,8 +519,7 @@ auto Endpoint::WriteLoop(uint32_t id,
                     absl::Time timestamp,
                     std::vector<EventEngine::Endpoint::WriteMetric> metrics) {
                   ztrace_collector->Append(
-                      [event, timestamp, &metrics,
-                       telemetry_info = std::move(telemetry_info)]() {
+                      [event, timestamp, &metrics, &telemetry_info]() {
                         EndpointWriteMetricsTrace trace{timestamp, event, {}};
                         trace.metrics.reserve(metrics.size());
                         for (const auto [id, value] : metrics) {

src/core/ext/transport/chttp2/transport/chttp2_transport.cc

@@ -1186,6 +1186,7 @@ static void write_action(
   // Choose max_frame_size as the preferred rx crypto frame size indicated by
   // the peer.
   grpc_event_engine::experimental::EventEngine::Endpoint::WriteArgs args;
+  std::vector<size_t> write_metrics;
   int max_frame_size =
       t->settings.peer().preferred_receive_crypto_message_size();
   // Note: max frame size is 0 if the remote peer does not support adjusting the
@@ -1202,8 +1203,9 @@ static void write_action(
     if (ee_ep != nullptr) {
       auto telemetry_info = ee_ep->GetTelemetryInfo();
       if (telemetry_info != nullptr) {
+        write_metrics = telemetry_info->AllWriteMetrics();
         args.set_metrics_sink(WriteEventSink(
-            {telemetry_info->AllWriteMetrics()},
+            write_metrics,
             {WriteEvent::kSendMsg, WriteEvent::kScheduled, WriteEvent::kSent,
              WriteEvent::kAcked},
             [tcp_call_tracers = std::move(tcp_call_tracers),

src/core/handshaker/security/secure_endpoint.cc

@@ -702,8 +702,9 @@ class SecureEndpoint final : public EventEngine::Endpoint {
    public:
     class TelemetryInfo : public EventEngine::Endpoint::TelemetryInfo {
      public:
-      TelemetryInfo(std::shared_ptr<EventEngine::Endpoint::TelemetryInfo>
-                        wrapped_telemetry_info)
+      explicit TelemetryInfo(
+          std::shared_ptr<EventEngine::Endpoint::TelemetryInfo>
+              wrapped_telemetry_info)
           : wrapped_telemetry_info_(std::move(wrapped_telemetry_info)) {}
 
       std::vector<size_t> AllWriteMetrics() const override {

test/core/event_engine/fuzzing_event_engine/fuzzing_event_engine.cc

@@ -477,17 +477,15 @@ class FuzzingEventEngine::FuzzingEndpoint::TelemetryInfo
     return out;
   }
 
-  virtual std::optional<absl::string_view> GetMetricName(
-      size_t key) const override {
+  std::optional<absl::string_view> GetMetricName(size_t key) const override {
     auto it = g_fuzzing_event_engine->endpoint_metrics_by_id_.find(key);
     if (it == g_fuzzing_event_engine->endpoint_metrics_by_id_.end()) {
       return std::nullopt;
     }
     return it->second;
   }
 
-  virtual std::optional<size_t> GetMetricKey(
-      absl::string_view name) const override {
+  std::optional<size_t> GetMetricKey(absl::string_view name) const override {
     auto it = g_fuzzing_event_engine->endpoint_metrics_by_name_.find(
         std::string(name));
     if (it == g_fuzzing_event_engine->endpoint_metrics_by_name_.end()) {