Skip to content

Commit c36799e

Browse files
yashyktcopybara-github
authored andcommitted
[MetricsTest] Reduce test logging (grpc#38582)
This is timing out on our windows portability tests on of the tests that registers 10000 stats plugins. This log line ends up getting executed probably around ~20k times causing timeout. Closes grpc#38582 COPYBARA_INTEGRATE_REVIEW=grpc#38582 from yashykt:MetricsTestLogging 137f850 PiperOrigin-RevId: 720305985
1 parent 682ae95 commit c36799e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test/core/telemetry/metrics_test.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -706,6 +706,8 @@ TEST_F(MetricsDeathTest, RegisterTheSameMetricNameWouldCrash) {
706706
int main(int argc, char** argv) {
707707
grpc::testing::TestEnvironment env(&argc, argv);
708708
::testing::InitGoogleTest(&argc, argv);
709+
grpc_core::GlobalInstrumentsRegistryTestPeer::
710+
ResetGlobalInstrumentsRegistry();
709711
int ret = RUN_ALL_TESTS();
710712
return ret;
711713
}

test/core/test_util/fake_stats_plugin.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,6 @@ class FakeStatsPlugin : public StatsPlugin {
224224
descriptor) {
225225
if (!use_disabled_by_default_metrics &&
226226
!descriptor.enable_by_default) {
227-
VLOG(2) << "FakeStatsPlugin[" << this
228-
<< "]: skipping disabled metric: " << descriptor.name;
229227
return;
230228
}
231229
switch (descriptor.instrument_type) {

0 commit comments

Comments
 (0)