Skip to content

Commit d87a9e6

Browse files
ctillercopybara-github
authored andcommitted
[sanity] Fix (grpc#39864)
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#39864 COPYBARA_INTEGRATE_REVIEW=grpc#39864 from ctiller:ugh ebf4455 PiperOrigin-RevId: 771451530
1 parent 929e3f6 commit d87a9e6

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/core/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8552,6 +8552,7 @@ grpc_cc_library(
85528552
"ext/transport/chaotic_good/scheduler.h",
85538553
],
85548554
external_deps = [
8555+
"absl/log",
85558556
"absl/strings",
85568557
],
85578558
deps = [

src/core/ext/transport/chaotic_good/scheduler.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,7 @@ class ParseConfig {
8787
// override ChooseChannel.
8888
class SimpleScheduler : public Scheduler {
8989
public:
90-
void NewStep(double outstanding_bytes, double min_tokens) override {
91-
channels_.clear();
92-
}
90+
void NewStep(double, double) override { channels_.clear(); }
9391

9492
void SetConfig(absl::string_view name, absl::string_view value) override {
9593
LOG(ERROR) << "SimpleScheduler::SetConfig: " << name << "=" << value;
@@ -100,7 +98,7 @@ class SimpleScheduler : public Scheduler {
10098
channels_.emplace_back(Channel{id, ready, start_time, bytes_per_second});
10199
}
102100

103-
void MakePlan(TcpZTraceCollector& ztrace_collector) override {
101+
void MakePlan(TcpZTraceCollector&) override {
104102
num_ready_ = std::partition(channels_.begin(), channels_.end(),
105103
[](const Channel& a) { return a.ready; }) -
106104
channels_.begin();

test/core/channelz/property_list_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414

1515
#include "src/core/channelz/property_list.h"
1616

17-
#include "src/core/util/json/json.h"
1817
#include "gmock/gmock.h"
1918
#include "gtest/gtest.h"
19+
#include "src/core/util/json/json.h"
2020

2121
namespace grpc_core {
2222
namespace channelz {

0 commit comments

Comments
 (0)