Skip to content

Commit e9e992f

Browse files
yasinBursaliclaude
andcommitted
docs(host-agent): drop stale --no-deps from post-install recreate explainers
PR Light-Heart-Labs#1021 dropped --no-deps from the install command path. Three comments in this branch's neighborhood still referenced the old form when explaining WHY the post-install core recreate is needed: bin/dream-host-agent.py:348 docstring of _post_install_core_recreate bin/dream-host-agent.py:1260 call-site comment in _handle_install tests/test_host_agent.py:328 comment block above TestPostInstallCoreRecreate The underlying causal claim is unchanged: docker compose up -d <ext> won't recreate already-running siblings without --force-recreate. Comments now describe the present-day install command accurately, with the missing --force-recreate flag named as the reason recreate is required, instead of the no-longer-passed --no-deps flag. No behaviour change. 45 host-agent tests still pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 900bc71 commit e9e992f

2 files changed

Lines changed: 11 additions & 10 deletions

File tree

dream-server/bin/dream-host-agent.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -345,11 +345,11 @@ def _post_install_core_recreate(service_id: str) -> None:
345345
"""Force-recreate core services whose env was overridden by ``service_id``'s
346346
compose.yaml overlay.
347347
348-
``docker compose up -d --no-deps <ext>`` (how _handle_install starts the
349-
extension) will not pick up overlay changes targeting already-running core
350-
services. openclaw's compose.yaml appends an OPENAI_API_BASE_URLS entry to
351-
open-webui; without this post-install recreate that overlay is silently
352-
ignored until the next core restart.
348+
``docker compose up -d <ext>`` (how _handle_install starts the extension)
349+
will not pick up overlay changes targeting already-running core services
350+
without ``--force-recreate``. openclaw's compose.yaml appends an
351+
OPENAI_API_BASE_URLS entry to open-webui; without this post-install
352+
recreate that overlay is silently ignored until the next core restart.
353353
354354
Failure is logged and swallowed — the extension itself is already running;
355355
the overlay will apply on the next manual restart of the core service.
@@ -1257,8 +1257,8 @@ def _run_install():
12571257

12581258
# Step 5: Post-install core recreate (best-effort, non-fatal).
12591259
# Some extensions (e.g. openclaw) add overlay env to already-
1260-
# running core services; `up -d --no-deps <ext>` won't apply
1261-
# those changes. Failure here must not fail the install.
1260+
# running core services; `up -d <ext>` (without --force-recreate)
1261+
# won't apply those changes. Failure here must not fail the install.
12621262
try:
12631263
_post_install_core_recreate(service_id)
12641264
except Exception:

dream-server/extensions/services/dashboard-api/tests/test_host_agent.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -325,9 +325,10 @@ def test_docker_compose_recreate_still_uses_no_deps(self):
325325
# --- _post_install_core_recreate ---
326326
#
327327
# openclaw's compose.yaml adds OPENAI_API_BASE_URLS to open-webui as an overlay;
328-
# `docker compose up -d --no-deps openclaw` (used by _handle_install) won't
329-
# pick up overlay changes targeting already-running core services. Hence the
330-
# post-install recreate of open-webui whenever openclaw is installed.
328+
# `docker compose up -d openclaw` (used by _handle_install) won't pick up
329+
# overlay changes targeting already-running core services without
330+
# `--force-recreate`. Hence the post-install recreate of open-webui whenever
331+
# openclaw is installed.
331332

332333

333334
class TestPostInstallCoreRecreate:

0 commit comments

Comments
 (0)