[WSL2] Installer (07-devtools): reinstall corrupts opencode.json — sed strips trailing comma → invalid JSON, opencode-web crash-loops

[yasinBursali]

Environment

• OS: Windows / WSL2 (Linux 6.6.87.2-microsoft-standard-WSL2)
• Docker version: 29.3.1
• GPU: NVIDIA GeForce RTX 3070 Laptop (8GB VRAM)
• DreamServer version/commit: local QA branch off upstream/main at cd11612 (merge of PR feat(extensions): service templates — curated multi-extension presets Light-Heart-Labs/DreamServer#887) + locally-merged PRs feat(dashboard): status tooltips, legend, and Extensions visual alignment Light-Heart-Labs/DreamServer#865, fix(macos-installer): guard Bash 4+ and auto-install via Homebrew Light-Heart-Labs/DreamServer#889, fix(dashboard-api): invalidate .compose-flags via host agent on mutations Light-Heart-Labs/DreamServer#890, fix(extensions): clean up stale progress files on disable/uninstall Light-Heart-Labs/DreamServer#891, fix(extensions): clean up stale progress files on purge Light-Heart-Labs/DreamServer#892
• Install command used: ./install.sh --tier 1 --non-interactive

Description

On a reinstall (when ~/.config/opencode/opencode.json already exists from a prior install), the installer's "update API key and URL in existing config" code path uses sed to rewrite the baseURL line. The sed pattern is greedy through end-of-line and drops the trailing comma, leaving:

"options": {
    "baseURL": "http://127.0.0.1:11434/v1"   <-- missing comma
    "apiKey": "no-key"
},

That is invalid JSON. The downstream opencode-web.service (user systemd unit) parses the file with cp opencode.json config.json, fails with CommaExpected at line 11, column 9, and goes into a permanent crash-loop. On my machine the systemd restart counter had reached 1265 by the time I noticed, because the broken state survives across reboots.

The from-scratch heredoc generator on lines 127–152 is fine — it only triggers the bug on the update path on lines 156–157.

Steps to Reproduce

1. Run ./install.sh --tier 1 on a clean machine — install succeeds, ~/.config/opencode/opencode.json is generated correctly with valid JSON.
2. Run the installer a second time (any tier, any flags) — the existing-file branch in 07-devtools.sh runs the two sed commands.
3. cat ~/.config/opencode/opencode.json — observe the missing comma after "baseURL".
4. systemctl --user status opencode-web — observe Active: activating (auto-restart) (Result: exit-code) with high restart counter.
5. journalctl --user -u opencode-web -n 50 — confirms CommaExpected at line 11, column 9.

Expected Behavior

A reinstall should leave opencode.json as valid JSON. The OpenCode Web service should start successfully on 127.0.0.1:3003.

Actual Behavior

opencode.json becomes invalid JSON after the first reinstall. opencode-web.service crash-loops indefinitely. Port 3003 never comes up. The installer's "Linking OpenCode Web" phase blocks for ~2 minutes waiting for the service before timing out and continuing.

Relevant Logs / Output

dream-server/installers/phases/07-devtools.sh:155-157:

# Reinstall: update API key and URL in existing config (key may have changed)
_sed_i "s|\"apiKey\":.*|\"apiKey\": \"${_opencode_key}\"|" "$OPENCODE_CONFIG_DIR/opencode.json"
_sed_i "s|\"baseURL\":.*|\"baseURL\": \"${_opencode_url}\"|" "$OPENCODE_CONFIG_DIR/opencode.json"

The .* in "baseURL":.* matches through the trailing , on the original line, and the replacement string does not put it back.

journalctl excerpt:

opencode[61671]: --- Errors ---
opencode[61671]: CommaExpected at line 11, column 9
opencode[61671]:    Line 11:         "apiKey": "no-key"
opencode[61671]:                   ^
opencode[61671]: --- End ---
systemd[233]: opencode-web.service: Failed with result 'exit-code'.
systemd[233]: opencode-web.service: Scheduled restart job, restart counter is at 1265.

Root Cause Hypothesis

The two sed patterns at 07-devtools.sh:156-157 are not JSON-aware. They match to end-of-line via .*, which on the baseURL line consumes the trailing , separator. The apiKey line is the last key inside options so it has no trailing comma — the apiKey sed is harmless. The baseURL sed is the corrupting one.

Two reasonable fixes (in increasing order of robustness):

1. Cheap fix — preserve the trailing comma explicitly in the replacement:

   _sed_i "s|\"baseURL\": *\"[^\"]*\"|\"baseURL\": \"${_opencode_url}\"|" "$OPENCODE_CONFIG_DIR/opencode.json"
   _sed_i "s|\"apiKey\": *\"[^\"]*\"|\"apiKey\": \"${_opencode_key}\"|"  "$OPENCODE_CONFIG_DIR/opencode.json"

   Match only the quoted value, leave the rest of the line (including the comma) untouched.

2. Robust fix — use jq if available, fall back to the regenerate-from-template path:

   if command -v jq >/dev/null 2>&1; then
     jq --arg url "$_opencode_url" --arg key "$_opencode_key" \
       '.provider["llama-server"].options.baseURL = $url
        | .provider["llama-server"].options.apiKey = $key' \
       "$OPENCODE_CONFIG_DIR/opencode.json" > "$OPENCODE_CONFIG_DIR/opencode.json.tmp" \
       && mv "$OPENCODE_CONFIG_DIR/opencode.json.tmp" "$OPENCODE_CONFIG_DIR/opencode.json"
   else
     # Fall back to the heredoc — overwrite is safer than a broken sed
     ...
   fi

Either fix should also re-sync config.json from opencode.json (the existing cp on line 161 already does this).

Severity / Impact

Medium. Doesn't break the main DreamServer stack — Open WebUI / llama-server / dashboard all install fine. But:

• OpenCode Web (port 3003) is silently broken on every reinstall.
• The installer's "Linking OpenCode Web" phase wastes ~2 minutes waiting for a service that will never come up.
• A naive user re-running ./install.sh to update will degrade their working OpenCode Web setup. The bug is silent — the installer prints ✓ OpenCode config updated (API key and URL refreshed) even though it just corrupted the file.

[yasinBursali]

Verification Result — CONFIRMED

Verified against: upstream/main at c0600ca3
Platform scope: Linux + WSL2 only (macOS is NOT affected — reasoning below)

Evidence

File examined: dream-server/installers/phases/07-devtools.sh

The from-scratch heredoc (lines 127–152) generates the following JSON structure:

      "options": {
        "baseURL": "http://127.0.0.1:8080/v1",
        "apiKey": "no-key"
      },

Note: "baseURL" is not the last key in options — it has a trailing comma.

The reinstall branch (lines 154–158):

else
    # Reinstall: update API key and URL in existing config (key may have changed)
    _sed_i "s|\"apiKey\":.*|\"apiKey\": \"\"|" "/opencode.json"
    _sed_i "s|\"baseURL\":.*|\"baseURL\": \"\"|" "/opencode.json"
    ai_ok "OpenCode config updated (API key and URL refreshed)"
fi

Corrupting line — 07-devtools.sh:157:

_sed_i "s|\"baseURL\":.*|\"baseURL\": \"\"|" "/opencode.json"

_sed_i definition — installers/lib/constants.sh:62:

_sed_i() {
    if sed --version 2>/dev/null | grep -q GNU; then
        sed -i ""
    else
        sed -i '' ""
    fi
}

Analysis

The sed pattern "baseURL":.* uses .* which is greedy and matches everything from "baseURL": to end-of-line. On the baseURL line that end-of-line content is:

 "http://127.0.0.1:8080/v1",

The trailing , is part of the match. The replacement string "baseURL": "" does not include a trailing comma. The comma is consumed and not restored.

The apiKey sed (line 156) is harmless: apiKey is the last key inside options, so its line has no trailing comma. The .* there matches only whitespace + the quoted value — nothing is lost.

Reproduction trace

Before (valid JSON, written by heredoc on first install):

        "baseURL": "http://127.0.0.1:8080/v1",
        "apiKey": "no-key"

After sed at line 157 (invalid JSON):

        "baseURL": "http://127.0.0.1:8080/v1"
        "apiKey": "no-key"

The missing comma makes options invalid JSON. opencode parses it and emits:

CommaExpected at line 11, column 9

exactly as reported.

macOS scope — NOT affected

installers/macos/install-macos.sh lines 828–830 (the macOS reinstall branch) are:

else
    ai_ok "OpenCode config already exists"
fi

No sed operations are executed on reinstall on macOS. The macOS installer silently skips the update entirely (which means the URL/key are also not refreshed on macOS reinstall, but that is a separate, lesser issue).

The _sed_i function (BSD vs GNU abstraction) exists only in installers/lib/constants.sh, which is sourced by the Linux installer — not by install-macos.sh, which has its own lib stack.

---

Verified via static code analysis on 2026-04-11. Automated verifier comment.

[yasinBursali]

Fixed by Light-Heart-Labs#901 (draft).

[yasinBursali]

Heads up — recovery hole in the closing fix (PR Light-Heart-Labs#901)

Reopening the conversation here because I found a real runtime gap in the fix this issue was closed by, and the previous comment thread is the right place for context.

TL;DR

PR Light-Heart-Labs#901 fixed the WRITE path so new installs don't corrupt opencode.json. But it does NOT recover from EXISTING corruption: when jq is installed AND the existing file is already malformed (i.e. left over from a pre-Light-Heart-Labs#901 install — which is exactly the symptom this issue described), jq's parse fails and the new code logs ai_warn "OpenCode config jq rewrite failed; leaving existing config in place" and keeps the broken file. The narrow-sed fallback only runs in the else (no-jq) branch — it never runs as recovery for jq parse failure.

Reproduction (on the integration of the open PR stack with Light-Heart-Labs#901 merged)

The previous install left behind exactly the symptom this issue described — baseURL and apiKey siblings without a separator comma:

"options": {
  "baseURL": "http://127.0.0.1:11434/v1"
  "apiKey": "no-key"
},

After running bash install.sh --all --non-interactive --no-comfyui from a branch with Light-Heart-Labs#901 merged, the install log line 101 shows:

⚠ OpenCode config jq rewrite failed; leaving existing config in place

The corrupt file is unchanged (mtime is still from the previous install — Apr 11 02:47). Manual jq reproduction:

$ jq --arg url "http://test/v1" --arg key "no-key" \
    '.provider["llama-server"].options.baseURL = $url
     | .provider["llama-server"].options.apiKey = $key' \
    ~/.config/opencode/opencode.json
jq: parse error: Expected separator between values at line 11, column 16
$ echo $?
5

jq -V → jq-1.7.

Code path

dream-server/installers/phases/07-devtools.sh:156-174:

if command -v jq >/dev/null 2>&1; then
    _opencode_tmp="$OPENCODE_CONFIG_DIR/opencode.json.tmp.$$"
    if jq --arg url ... '...' "$OPENCODE_CONFIG_DIR/opencode.json" > "$_opencode_tmp"; then
        mv "$_opencode_tmp" "$OPENCODE_CONFIG_DIR/opencode.json"
        ai_ok "OpenCode config updated (API key and URL refreshed)"
    else
        rm -f "$_opencode_tmp"
        ai_warn "OpenCode config jq rewrite failed; leaving existing config in place"
        # ← BUG: no fall-through to sed fallback
    fi
else
    # narrow-sed fallback — only runs when jq is ABSENT (not when jq parse fails)
    _sed_i "..."
fi

Effect

Users who were on a pre-Light-Heart-Labs#901 release that produced a corrupt opencode.json, then upgraded to a post-Light-Heart-Labs#901 release, are stuck with the broken file. They don't get out of it without rm ~/.config/opencode/opencode.json && re-run. This is the population this issue was filed to protect — they got the WRITE-path fix but not the RECOVERY-path fix.

Filed as a separate follow-up

Tracking the gap as #332 to keep the resolution discoverable. Two suggested fix options there:

• Option A: chain the sed fallback into the jq-failure branch (least invasive, but the narrow-sed regexes may not match every kind of corruption).
• Option B: when jq fails to parse, write a fresh config from the inline HEREDOC template at the top of the same function (most robust, deterministic recovery).

The full reproduction, code citations, and patch suggestions are at #332.

This issue can probably stay closed (the core fix from PR Light-Heart-Labs#901 is correct for new installs), but #332 should track the upgrade-path recovery gap separately.

---

Filed during full-stack integration test of open PR stack Light-Heart-Labs#893–909 on Light-Heart-Labs/DreamServer@c0600ca3. Environment: WSL2 / Ubuntu 24.04 / jq 1.7.