Skip to content

test: fix pre-existing 'Extension summary output' failure in test-doctor-extension-diagnostics.sh #404

@yasinBursali

Description

@yasinBursali

Summary

tests/test-doctor-extension-diagnostics.sh has one failing case ("Extension summary output") on both upstream/main and any feature branch based on it. The test uses grep "ext_total.*ext_healthy" expecting those fields on a single line, but dream-doctor.sh's JSON report emits them on separate lines.

Not caused by any recent PR — discovered while validating fix/dream-cli-apple-silicon-coverage on a real host (test expected pass, actual mismatch between grep assumption and output layout).

Suggested fix

Either:

  • Update the test to allow multi-line matching: grep -c "ext_total\|ext_healthy" then assert count ≥ 2.
  • Update the assertion to use jq against the JSON report: jq -e '.summary.ext_total and .summary.ext_healthy' report.json.

The jq form is more robust and matches the style used elsewhere in tests/.

Priority

Low — test gardening. The underlying functionality works; only the test assertion is wrong.

Origin

Spotted by the tester during validation of PR fix/dream-cli-apple-silicon-coverage.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions