Commit 5734301
authored
Fix Coverity static analysis defects (Feb) (openvinotoolkit#3376)
## Description
Fix three Coverity static analysis defects across speculative decoding,
LLM pipeline, and Whisper components.
- **CID 6415047 (INTEGER_OVERFLOW)**: Add boundary guards before
decrementing unsigned indices in DTW backtracking to prevent `size_t`
underflow -
[CVS-181400](https://jira.devtools.intel.com/projects/CVS/issues/CVS-181400)
- **CID 6419148 (MISSING_LOCK)**: Access `m_draft_generations_mutex`
field directly instead of through accessor in `generate_common`
template, so Coverity can correlate the lock with the guarded data -
[CVS-181402](https://jira.devtools.intel.com/projects/CVS/issues/CVS-181402)
- **CID 6415437 (NULL_FIELD)**: Add defensive assertion on
`main_model_descr.model` before passing it to `StatefulLLMPipeline`
constructor -
[CVS-181401](https://jira.devtools.intel.com/projects/CVS/issues/CVS-181401)1 parent 1e3fce5 commit 5734301
File tree
3 files changed
+12
-7
lines changed- src/cpp/src
- llm
- speculative_decoding/continuous_batching
- whisper
3 files changed
+12
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
| 154 | + | |
154 | 155 | | |
155 | | - | |
| 156 | + | |
156 | 157 | | |
157 | 158 | | |
158 | 159 | | |
| |||
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
199 | | - | |
200 | 199 | | |
201 | 200 | | |
202 | 201 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
272 | | - | |
273 | | - | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
274 | 275 | | |
275 | | - | |
| 276 | + | |
| 277 | + | |
276 | 278 | | |
277 | | - | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
278 | 283 | | |
279 | 284 | | |
280 | 285 | | |
| |||
0 commit comments