Adding progress bar

Author: szumal

cloud/filestore/apps/client/lib/diagnose_filesystem.cpp

@@ -170,6 +170,11 @@ class TDiagnoseFilesystemCommand final: public TFileStoreCommand
         TVector<TNodeRow>& accessRows,
         TVector<NAggregation::TRow<TLatency>>& latencyRows)
     {
+        if (BatchSize == 0) {
+            STORAGE_THROW_SERVICE_ERROR(
+                MakeError(E_ARGUMENT, "batch-size must be greater than zero"));
+        }
+        size_t completed = 0;
         for (int batchStart = 0; batchStart < shardStats.size();
              batchStart += BatchSize)
         {
@@ -214,7 +219,8 @@ class TDiagnoseFilesystemCommand final: public TFileStoreCommand
                                    << result.GetOutput())));
                     continue;
                 }
-
+                ++completed;
+                PrintProgress(completed, shardStats.size());
                 ProcessAccessStats(response.GetNodeStats(), accessRows);
                 ProcessLatencyStats(response.GetLatencyStats(), latencyRows);
             }
@@ -238,6 +244,25 @@ class TDiagnoseFilesystemCommand final: public TFileStoreCommand
             std::move(request));
     }
 
+    void PrintProgress(size_t completed, size_t total)
+    {
+        if (JsonOutput) {
+            return;
+        }
+
+        size_t width = 40;
+        size_t filled = total ? completed * width / total : width;
+
+        Cout << '\r' << "Collecting access and latency stats ["
+             << TString(filled, '#') << TString(width - filled, '_') << "] "
+             << completed << '/' << total
+             << Flush;
+
+        if (completed == total) {
+            Cout << Endl;
+        }
+    }
+
     void ProcessAccessStats(
         const google::protobuf::RepeatedPtrField<
             NCloud::NFileStore::NProtoPrivate::TNodeStats>& accessStats,

cloud/filestore/libs/storage/core/config.cpp

@@ -326,7 +326,7 @@ using TAliases = NProto::TStorageConfig::TFilestoreAliases;
     xxx(BlockChecksumsInProfileLogEnabled, bool,      false                   )\
                                                                                \
     xxx(MinShardCount,                     ui32,      0                       )\
-    xxx(MaxShardCount,                     ui32,      254                     )\
+    xxx(MaxShardCount,                     ui32,      1000                    )\
                                                                                \
     xxx(ReadBlobDisabled,                  bool,      false                   )\
     xxx(WriteBlobDisabled,                 bool,      false                   )\