Skip to content

measurement_type="mean" in BlobDetector equals "max" without reference image #6

Open
@shachafl

Description

@shachafl

Description

measurement_type="mean" in BlobDetector equals "max" without reference image.
Also, missing fields "z_min","z_max","y_min","y_max","x_min","x_max" in spots object when not using a reference image

Steps/Code to Reproduce

run any example w/out reference image and change measurement_type between "max" and "mean".

bd = starfish.spots.FindSpots.BlobDetector(
min_sigma=1,
max_sigma=2,
num_sigma=2,
threshold=np.percentile(np.ravel(stack.xarray.values), 95),
overlap = 0.5,
measurement_type = "max",
exclude_border=1,
detector_method='blob_log')

spots = bd.run(stack)

Expected Results

Different intensity results when using "max" or "mean" as can be seen when using a reference image

Actual Results

Same intensity results when using "max" or "mean" when not using a ref image.

Versions

starfish 0+untagged.1442.g041c830.dirty

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions