feat(pom): upgrade qulice to 0.31.1

Bump qulice-maven-plugin to 0.31.1 and satisfy the checks it adds: drop
Javadoc from private methods, hoist the identity comparison out of the
lambda in every equals so ErrorProne sees it inside equals itself,
delegate to Objects#equals in EqualsNullable, compare instances with
IsSame instead of ==, count integers without boxing, repeat the threaded
Solid test instead of calling one test from another, and remove the
List#remove ambiguity by typing the list on String

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: yegor256

src/main/java/org/cactoos/io/TailOf.java

@@ -80,13 +80,6 @@ public InputStream stream() throws Exception {
         return new ByteArrayInputStream(response, 0, num);
     }
 
-    /**
-     * Copy full buffer to response.
-     * @param buffer The buffer array
-     * @param response The response array
-     * @param read Number of bytes read in buffer
-     * @return Number of bytes in the response buffer
-     */
     private int copy(final byte[] buffer, final byte[] response,
         final int read) {
         System.arraycopy(
@@ -95,14 +88,6 @@ private int copy(final byte[] buffer, final byte[] response,
         return new MinOf(this.count, read).intValue();
     }
 
-    /**
-     * Copy buffer to response for read count smaller then buffer size.
-     * @param buffer The buffer array
-     * @param response The response array
-     * @param num Number of bytes in response array from previous read
-     * @param read Number of bytes read in the buffer
-     * @return New count of bytes in the response array
-     */
     private int copyPartial(final byte[] buffer, final byte[] response,
         final int num, final int read) {
         final int result;

src/main/java/org/cactoos/io/WriterAsOutputStream.java

@@ -174,14 +174,6 @@ public void close() throws IOException {
         this.writer.close();
     }
 
-    /**
-     * Write a portion from the buffer.
-     * @param buffer The buffer
-     * @param offset Offset in the buffer
-     * @param length Maximum possible amount to take
-     * @return How much was taken
-     * @throws IOException If fails
-     */
     private int next(final byte[] buffer, final int offset,
         final int length) throws IOException {
         final ByteBuffer ibuf = this.input.value();

src/main/java/org/cactoos/iterable/IterableOf.java

@@ -12,7 +12,6 @@
 import org.cactoos.iterator.IteratorOf;
 import org.cactoos.scalar.And;
 import org.cactoos.scalar.HashCode;
-import org.cactoos.scalar.Or;
 import org.cactoos.scalar.ScalarWithFallback;
 import org.cactoos.scalar.Unchecked;
 import org.cactoos.text.Joined;
@@ -69,32 +68,29 @@ public Iterator<X> iterator() {
     @SuppressFBWarnings("EQ_UNUSUAL")
     @SuppressWarnings("unchecked")
     public boolean equals(final Object other) {
-        return new Unchecked<>(
-            new Or(
-                () -> other == this,
-                new And(
-                    () -> other != null,
-                    () -> Iterable.class.isAssignableFrom(other.getClass()),
-                    () -> new ScalarWithFallback<>(
-                        new And(
-                            (X value) -> true,
-                            new Matched<>(
-                                this,
-                                (Iterable<X>) other
-                            )
+        return other == this || new Unchecked<>(
+            new And(
+                () -> other != null,
+                () -> Iterable.class.isAssignableFrom(other.getClass()),
+                () -> new ScalarWithFallback<>(
+                    new And(
+                        (X value) -> true,
+                        new Matched<>(
+                            this,
+                            (Iterable<X>) other
+                        )
+                    ),
+                    new org.cactoos.iterable.IterableOf<>(
+                        new Fallback.From<>(
+                            IllegalStateException.class,
+                            ex -> false
                         ),
-                        new org.cactoos.iterable.IterableOf<>(
-                            new Fallback.From<>(
-                                IllegalStateException.class,
-                                ex -> false
-                            ),
-                            new Fallback.From<>(
-                                NoSuchElementException.class,
-                                ex -> false
-                            )
+                        new Fallback.From<>(
+                            NoSuchElementException.class,
+                            ex -> false
                         )
-                    ).value()
-                )
+                    )
+                ).value()
             )
         ).value();
     }

src/main/java/org/cactoos/iterator/Sliced.java

@@ -94,9 +94,6 @@ public T next() {
         return this.iterator.next();
     }
 
-    /**
-     * Skips head elements up to start index.
-     */
     private void skip() {
         while (this.current < this.start && this.iterator.hasNext()) {
             this.iterator.next();

src/main/java/org/cactoos/list/JoinedListIterator.java

@@ -166,26 +166,14 @@ public void add(final T elt) {
         throw new UnsupportedOperationException();
     }
 
-    /**
-     * If {@link List} of {@link ListIterator} has next element.
-     * @return Has or no
-     */
     private boolean listHasNextElt() {
         return this.cursorlit.get() + 1 <= this.listiters.value().size() - 1;
     }
 
-    /**
-     * If {@link List} of {@link ListIterator} has previous element.
-     * @return Has or no
-     */
     private boolean listHasPreviousElt() {
         return this.cursorlit.get() - 1 >= 0;
     }
 
-    /**
-     * Get current {@link ListIterator}.
-     * @return Current element
-     */
     private ListIterator<? extends T> currentListIterator() {
         final ListIterator<? extends T> current;
         if (this.cursorlit.get() == -1) {

src/main/java/org/cactoos/scalar/Checked.java

@@ -60,14 +60,6 @@ public T value() throws E {
         }
     }
 
-    /**
-     * Wraps exception.
-     * Skips unnecessary wrapping of exceptions of the same type.
-     * Allows wrapping of exceptions of the same type if the error message
-     * has been changed.
-     * @param exp Exception
-     * @return E Wrapped exception
-     */
     @SuppressWarnings("unchecked")
     private E wrappedException(final Exception exp) {
         E wrapped = new UncheckedFunc<>(this.func).apply(exp);

src/main/java/org/cactoos/scalar/EqualsNullable.java

@@ -4,6 +4,7 @@
  */
 package org.cactoos.scalar;
 
+import java.util.Objects;
 import org.cactoos.Scalar;
 
 /**
@@ -65,11 +66,7 @@ public EqualsNullable(final Scalar<? extends Object> first,
     }
 
     @Override
-    @SuppressWarnings("PMD.CompareObjectsWithEquals")
     public Boolean value() throws Exception {
-        final Object source = this.first.value();
-        final Object compared = this.second.value();
-        return source == compared
-            || source != null && source.equals(compared);
+        return Objects.equals(this.first.value(), this.second.value());
     }
 }

src/main/java/org/cactoos/scalar/InheritanceLevel.java

@@ -58,10 +58,6 @@ public Integer value() {
         return level;
     }
 
-    /**
-     * Calculates inheritance level.
-     * @return Integer Level
-     */
     private int calculateLevel() {
         int level = Integer.MIN_VALUE;
         Class<?> sclass = this.derived.getSuperclass();

src/main/java/org/cactoos/scalar/ScalarWithFallback.java

@@ -76,13 +76,6 @@ public T value() throws Exception {
         return result;
     }
 
-    /**
-     * Finds the best fallback for the given exception type and apply it to
-     * the exception or throw the original error if no fallback found.
-     * @param exp The original exception
-     * @return Result of the most suitable fallback
-     * @throws Exception The original exception if no fallback found
-     */
     @SuppressWarnings("PMD.AvoidThrowingRawExceptionTypes")
     private T fallback(final Throwable exp) throws Exception {
         final Iterator<? extends Map.Entry<Fallback<? extends T>, Integer>> candidates =

src/main/java/org/cactoos/text/TextOfScalar.java

@@ -8,7 +8,6 @@
 import org.cactoos.Scalar;
 import org.cactoos.Text;
 import org.cactoos.scalar.And;
-import org.cactoos.scalar.Or;
 import org.cactoos.scalar.Unchecked;
 
 /**
@@ -51,15 +50,12 @@ public int hashCode() {
     @Override
     @SuppressFBWarnings("EQ_UNUSUAL")
     public boolean equals(final Object obj) {
-        return new Unchecked<>(
-            new Or(
-                () -> this == obj,
-                new And(
-                    () -> obj instanceof Text,
-                    () -> new UncheckedText(this)
-                        .asString()
-                        .equals(new UncheckedText((Text) obj).asString())
-                )
+        return this == obj || new Unchecked<>(
+            new And(
+                () -> obj instanceof Text,
+                () -> new UncheckedText(this)
+                    .asString()
+                    .equals(new UncheckedText((Text) obj).asString())
             )
         ).value();
     }