Skip to content

Commit 17c018b

Browse files
mshimaCopilotCopilot
authored
chore: replace assert with expect (#778)
* chore: replace assert with expect Co-authored-by: Copilot <copilot@github.com> * chore: drop yeoman-assert * fix: normalize line endings in help() tests for Windows compatibility Agent-Logs-Url: https://github.com/yeoman/environment/sessions/39b4a214-ad9b-44c4-9c38-a15ad8ee9e17 Co-authored-by: mshima <1417183+mshima@users.noreply.github.com> * fix: use not.toBe for reference inequality check Agent-Logs-Url: https://github.com/yeoman/environment/sessions/39b4a214-ad9b-44c4-9c38-a15ad8ee9e17 Co-authored-by: mshima <1417183+mshima@users.noreply.github.com> --------- Co-authored-by: Copilot <copilot@github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mshima <1417183+mshima@users.noreply.github.com>
1 parent 14f7bf7 commit 17c018b

6 files changed

Lines changed: 351 additions & 354 deletions

File tree

‎package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@
9494
"rimraf": "^6.1.3",
9595
"strip-ansi": "^7.2.0",
9696
"typescript": "6.0.3",
97-
"yeoman-assert": "^3.1.1",
9897
"yeoman-environment": "file:./",
9998
"yeoman-generator-2": "npm:yeoman-generator@^2.0.5",
10099
"yeoman-generator-4": "npm:yeoman-generator@^4.13.0",

‎test/command.ts‎

Lines changed: 25 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
/* eslint-disable @typescript-eslint/ban-ts-comment */
22
// @ts-nocheck
3-
import assert from 'node:assert';
43
import path, { dirname } from 'node:path';
54
import { fileURLToPath } from 'node:url';
65
import { beforeEach, describe, esmocha, expect, it } from 'esmocha';
@@ -66,16 +65,16 @@ describe('environment (command)', () => {
6665
beforeEach(async () => {
6766
await environment.execute('commands:options');
6867
const generators = Object.values(environment.composedStore.getGenerators()) as ParsedGenerator[];
69-
assert.ok(generators.length === 1);
68+
expect(generators.length).toEqual(1);
7069
generator = generators[0];
7170
});
7271

7372
it('should parse options correctly', () => {
74-
assert.strictEqual(generator.options.bool, undefined);
75-
assert.strictEqual(generator.options.boolDefault, true);
73+
expect(generator.options.bool).toBe(undefined);
74+
expect(generator.options.boolDefault).toBe(true);
7675

77-
assert.strictEqual(generator.options.string, undefined);
78-
assert.strictEqual(generator.options.stringDefault, 'defaultValue');
76+
expect(generator.options.string).toBe(undefined);
77+
expect(generator.options.stringDefault).toBe('defaultValue');
7978
});
8079
});
8180

@@ -92,16 +91,16 @@ describe('environment (command)', () => {
9291
]);
9392

9493
const generators = Object.values(environment.composedStore.getGenerators()) as ParsedGenerator[];
95-
assert.ok(generators.length === 1);
94+
expect(generators.length).toEqual(1);
9695
generator = generators[0];
9796
});
9897

9998
it('should parse options correctly', () => {
100-
assert.strictEqual(generator.options.bool, true);
101-
assert.strictEqual(generator.options.boolDefault, false);
99+
expect(generator.options.bool).toBe(true);
100+
expect(generator.options.boolDefault).toBe(false);
102101

103-
assert.strictEqual(generator.options.string, 'customValue');
104-
assert.strictEqual(generator.options.stringDefault, 'newValue');
102+
expect(generator.options.string).toBe('customValue');
103+
expect(generator.options.stringDefault).toBe('newValue');
105104
});
106105
});
107106

@@ -110,13 +109,13 @@ describe('environment (command)', () => {
110109
beforeEach(async () => {
111110
await environment.execute('commands:options', ['-b', '-s', 'customValue']);
112111
const generators = Object.values(environment.composedStore.getGenerators()) as ParsedGenerator[];
113-
assert.ok(generators.length === 1);
112+
expect(generators.length).toEqual(1);
114113
generator = generators[0];
115114
});
116115

117116
it('should parse options correctly', () => {
118-
assert.strictEqual(generator.options.bool, true);
119-
assert.strictEqual(generator.options.string, 'customValue');
117+
expect(generator.options.bool).toBe(true);
118+
expect(generator.options.string).toBe('customValue');
120119
});
121120
});
122121
});
@@ -137,12 +136,12 @@ describe('environment (command)', () => {
137136
beforeEach(async () => {
138137
await environment.execute('commands:arguments');
139138
const generators = Object.values(environment.composedStore.getGenerators()) as ParsedGenerator[];
140-
assert.ok(generators.length === 1);
139+
expect(generators.length).toEqual(1);
141140
generator = generators[0];
142141
});
143142

144143
it('should parse arguments correctly', () => {
145-
assert.deepStrictEqual(generator._args, []);
144+
expect(generator._args).toEqual([]);
146145
});
147146
});
148147

@@ -151,16 +150,16 @@ describe('environment (command)', () => {
151150
beforeEach(async () => {
152151
await environment.execute('commands:arguments', ['foo']);
153152
const generators = Object.values(environment.composedStore.getGenerators()) as ParsedGenerator[];
154-
assert.ok(generators.length === 1);
153+
expect(generators.length).toEqual(1);
155154
generator = generators[0];
156155
});
157156

158157
it('should parse arguments correctly', () => {
159-
assert.deepStrictEqual(generator._args, ['foo']);
158+
expect(generator._args).toEqual(['foo']);
160159
});
161160

162161
it('should load arguments into options', () => {
163-
assert.strictEqual(generator.options.name, 'foo');
162+
expect(generator.options.name).toBe('foo');
164163
});
165164
});
166165
});
@@ -180,12 +179,12 @@ describe('environment (command)', () => {
180179

181180
environment = command.env;
182181
const generators = Object.values(environment.composedStore.getGenerators()) as ParsedGenerator[];
183-
assert.ok(generators.length === 1);
182+
expect(generators.length).toEqual(1);
184183
generator = generators[0];
185184
});
186185

187186
it('should parse arguments correctly', () => {
188-
assert.deepStrictEqual(generator._args, ['bar']);
187+
expect(generator._args).toEqual(['bar']);
189188
});
190189
});
191190
});
@@ -211,16 +210,16 @@ describe('environment (command)', () => {
211210

212211
environment = command.env;
213212
const generators = Object.values(environment.composedStore.getGenerators()) as ParsedGenerator[];
214-
assert.ok(generators.length === 1);
213+
expect(generators.length).toEqual(1);
215214
generator = generators[0];
216215
});
217216

218217
it('should parse options correctly', () => {
219-
assert.strictEqual(generator.options.bool, true);
220-
assert.strictEqual(generator.options.boolDefault, false);
218+
expect(generator.options.bool).toBe(true);
219+
expect(generator.options.boolDefault).toBe(false);
221220

222-
assert.strictEqual(generator.options.string, 'customValue');
223-
assert.strictEqual(generator.options.stringDefault, 'newValue');
221+
expect(generator.options.string).toBe('customValue');
222+
expect(generator.options.stringDefault).toBe('newValue');
224223
});
225224
});
226225
});

0 commit comments

Comments
 (0)