bump xo to v0.60.0 (#876)

* bump xo to v0.60.0

* recreate package-lock.json

Author: mshima

lib/cli.js

@@ -1,39 +1,41 @@
 #!/usr/bin/env node
-'use strict';
 import fs from 'node:fs';
 import path from 'node:path';
+import process from 'node:process';
 import chalk from 'chalk';
 import updateNotifier from 'update-notifier';
 import yosay from 'yosay';
 import stringLength from 'string-length';
 import rootCheck from 'root-check';
 import meow from 'meow';
 import list from 'cli-list';
+import {bootstrap} from 'global-agent';
 import tabtab from './completion/tabtab.cjs';
 import pkg from './utils/project-package.js';
 import Router from './router.js';
-import {bootstrap} from 'global-agent';
 import * as routes from './routes/index.js';
 import {getDirname} from './utils/node-shims.js';
 
 const __dirname = getDirname(import.meta.url);
-const gens = list(process.argv.slice(2));
+const generators = list(process.argv.slice(2));
 
 bootstrap();
 
-const cli = gens.map(gen => {
-  const minicli = meow({autoHelp: false, autoVersion: true, pkg, argv: gen, importMeta: import.meta});
+const cli = generators.map(generator => {
+  const minicli = meow({
+    autoHelp: false, autoVersion: true, pkg, argv: generator, importMeta: import.meta,
+  });
   const options = minicli.flags;
-  const args = minicli.input;
+  const arguments_ = minicli.input;
 
   // Add un-camelized options too, for legacy
   // TODO: Remove some time in the future when generators have upgraded
   for (const key of Object.keys(options)) {
-    const legacyKey = key.replace(/[A-Z]/g, m => `-${m.toLowerCase()}`);
+    const legacyKey = key.replaceAll(/[A-Z]/g, m => `-${m.toLowerCase()}`);
     options[legacyKey] = options[key];
   }
 
-  return {opts: options, args};
+  return {opts: options, args: arguments_};
 });
 
 const firstCmd = cli[0] || {opts: {}, args: {}};
@@ -46,7 +48,7 @@ function updateCheck() {
   if (notifier.update) {
     message.push(
       'Update available: ' + chalk.green.bold(notifier.update.latest) + chalk.gray(' (current: ' + notifier.update.current + ')'),
-      'Run ' + chalk.magenta('npm install -g ' + pkg.name) + ' to update.'
+      'Run ' + chalk.magenta('npm install -g ' + pkg.name) + ' to update.',
     );
     console.log(yosay(message.join(' '), {maxLength: stringLength(message[0])}));
   }
@@ -55,8 +57,7 @@ function updateCheck() {
 async function pre() {
   // Debugging helper
   if (cmd === 'doctor') {
-    // eslint-disable-next-line node/no-unsupported-features/es-syntax
-    const yeomanDoctor = (await import('yeoman-doctor')).default;
+    const {default: yeomanDoctor} = await import('yeoman-doctor');
     yeomanDoctor();
     return;
   }
@@ -67,8 +68,7 @@ async function pre() {
 
   // Easteregg
   if (cmd === 'yeoman' || cmd === 'yo') {
-    // eslint-disable-next-line node/no-unsupported-features/es-syntax
-    const yeomanCharacter = (await import('yeoman-character')).default;
+    const {default: yeomanCharacter} = await import('yeoman-character');
     console.log(yeomanCharacter);
     return;
   }
@@ -82,9 +82,7 @@ function createGeneratorList(env) {
     const generatorName = parts.shift();
 
     // If first time we found this generator, prepare to save all its sub-generators
-    if (!namesByGenerator[generatorName]) {
-      namesByGenerator[generatorName] = [];
-    }
+    namesByGenerator[generatorName] ||= [];
 
     // If sub-generator (!== app), save it
     if (parts[0] !== 'app') {
@@ -111,7 +109,6 @@ const onError = error => {
 };
 
 async function init() {
-  // eslint-disable-next-line node/no-unsupported-features/es-syntax
   const {createEnv} = await import('yeoman-environment');
   const env = createEnv();
 
@@ -156,9 +153,9 @@ async function init() {
   // Note: at some point, nopt needs to know about the generator options, the
   // one that will be triggered by the below args. Maybe the nopt parsing
   // should be done internally, from the args.
-  for (const gen of cli) {
+  for (const generator of cli) {
     // eslint-disable-next-line no-await-in-loop
-    await env.run(gen.args, gen.opts).catch(error => onError(error));
+    await env.run(generator.args, generator.opts).catch(error => onError(error));
   }
 }
 
@@ -182,6 +179,7 @@ rootCheck('\n' + chalk.red('Easy with the `sudo`. Yeoman is the master around he
 
 updateCheck();
 
+// eslint-disable-next-line unicorn/prefer-top-level-await
 (async function () {
   await pre();
 })();

lib/completion/completer.cjs

@@ -1,6 +1,5 @@
-'use strict';
-const path = require('path');
-const {execFile} = require('child_process');
+const path = require('node:path');
+const {execFile} = require('node:child_process');
 const parseHelp = require('parse-help');
 
 /**
@@ -39,9 +38,9 @@ class Completer {
    */
   generator(data, done) {
     const {last} = data;
-    const bin = path.resolve(__dirname, '../cli.js');
+    const binary = path.resolve(__dirname, '../cli.js');
 
-    execFile('node', [bin, last, '--help'], (error, out) => {
+    execFile('node', [binary, last, '--help'], (error, out) => {
       if (error) {
         done(error);
         return;
@@ -62,13 +61,13 @@ class Completer {
     return item => {
       const name = typeof item === 'string' ? item : item.name;
       desc = typeof item !== 'string' && item.description ? item.description : desc;
-      desc = desc.replace(/^#?\s*/g, '');
-      desc = desc.replace(/:/g, '->');
-      desc = desc.replace(/'/g, ' ');
+      desc = desc.replaceAll(/^#?\s*/g, '');
+      desc = desc.replaceAll(':', '->');
+      desc = desc.replaceAll('\'', ' ');
 
       return {
         name: prefix + name,
-        description: desc
+        description: desc,
       };
     };
   }

lib/completion/index.cjs

@@ -1,13 +1,11 @@
 #! /usr/bin/env node
-'use strict';
 const tabtab = require('tabtab')({
   name: 'yo',
-  cache: !process.env.YO_TEST
+  cache: !require('node:process').env.YO_TEST,
 });
 const Completer = require('./completer.cjs');
 
 (async () => {
-  // eslint-disable-next-line node/no-unsupported-features/es-syntax
   const {createEnv} = await import('yeoman-environment');
   const completer = new Completer(createEnv());
 

lib/completion/tabtab.cjs

@@ -4,7 +4,7 @@ const Tabtab = require('tabtab');
 const tabtab = new Tabtab.Commands.default({
   name: 'yo',
   completer: 'yo-complete',
-  cache: false
+  cache: false,
 });
 
 module.exports = tabtab;

lib/router.js

@@ -1,5 +1,4 @@
-'use strict';
-import path from 'path';
+import path from 'node:path';
 import titleize from 'titleize';
 import humanizeString from 'humanize-string';
 import {readPackageUpSync} from 'read-pkg-up';
@@ -15,11 +14,11 @@ import pkg from './utils/project-package.js';
  * @param  {Configstore} [conf] An optional config store instance
  */
 export default class Router {
-  constructor(env, conf) {
+  constructor(env, config) {
     this.routes = {};
     this.env = env;
-    this.conf = conf || new Configstore(pkg.name, {
-      generatorRunCount: {}
+    this.conf = config || new Configstore(pkg.name, {
+      generatorRunCount: {},
     });
   }
 
@@ -29,9 +28,9 @@ export default class Router {
    * @param  {*}      arg  A single argument to pass to the route handler
    * @return  {Promise} Promise this.
    */
-  navigate(name, arg) {
+  navigate(name, argument) {
     if (typeof this.routes[name] === 'function') {
-      return this.routes[name].call(null, this, arg).then(() => this);
+      return this.routes[name].call(null, this, argument).then(() => this);
     }
 
     throw new Error(`No routes called: ${name}`);
@@ -60,22 +59,22 @@ export default class Router {
         return;
       }
 
-      const {packageJson: pkg} = readPackageUpSync({cwd: path.dirname(generator.resolved)});
+      const {packageJson: package_} = readPackageUpSync({cwd: path.dirname(generator.resolved)});
 
-      if (!pkg) {
+      if (!package_) {
         return;
       }
 
-      pkg.namespace = generator.namespace;
-      pkg.appGenerator = true;
-      pkg.prettyName = titleize(humanizeString(namespaceToName(generator.namespace)));
-      pkg.update = updateNotifier({pkg}).update;
+      package_.namespace = generator.namespace;
+      package_.appGenerator = true;
+      package_.prettyName = titleize(humanizeString(namespaceToName(generator.namespace)));
+      package_.update = updateNotifier({pkg: package_}).update;
 
-      if (pkg.update && pkg.version !== pkg.update.latest) {
-        pkg.updateAvailable = true;
+      if (package_.update && package_.version !== package_.update.latest) {
+        package_.updateAvailable = true;
       }
 
-      this.generators[pkg.name] = pkg;
+      this.generators[package_.name] = package_;
     };
 
     for (const generator of Object.values(this.env.getGeneratorsMeta())) {

lib/routes/clear-config.js

@@ -1,4 +1,3 @@
-'use strict';
 import _ from 'lodash';
 import chalk from 'chalk';
 import inquirer from 'inquirer';
@@ -9,8 +8,8 @@ export const clearConfig = async app => {
   const defaultChoices = [
     {
       name: 'Take me back home, Yo!',
-      value: 'home'
-    }
+      value: 'home',
+    },
   ];
 
   const generatorList = _.chain(globalConfig.getAll()).map((value, key) => {
@@ -32,26 +31,26 @@ export const clearConfig = async app => {
     return {
       name: prettyName,
       sort,
-      value: key
+      value: key,
     };
   }).compact().sortBy(generatorName => generatorName.sort).value();
 
   if (generatorList.length > 0) {
     generatorList.push(new inquirer.Separator());
     defaultChoices.unshift({
       name: 'Clear all',
-      value: '*'
+      value: '*',
     });
   }
 
   return inquirer.prompt([{
     name: 'whatNext',
     type: 'list',
     message: 'Which store would you like to clear?',
-    choices: _.flatten([
+    choices: [
       generatorList,
-      defaultChoices
-    ])
+      defaultChoices,
+    ].flat(),
   }]).then(answer => {
     if (answer.whatNext === 'home') {
       return app.navigate('home');

lib/routes/exit.js

@@ -1,4 +1,3 @@
-'use strict';
 import yosay from 'yosay';
 
 export const exit = async () => {
@@ -8,11 +7,11 @@ export const exit = async () => {
   const newLine = ' '.repeat(maxLength);
 
   console.log(yosay(
-    'Bye from us!' +
-    newLine +
-    'Chat soon.' +
-    newLine +
-    'Yeoman team ' + url,
-    {maxLength}
+    'Bye from us!'
+    + newLine
+    + 'Chat soon.'
+    + newLine
+    + 'Yeoman team ' + url,
+    {maxLength},
   ));
 };

lib/routes/help.js

@@ -1,31 +1,28 @@
-'use strict';
 import inquirer from 'inquirer';
 import open from 'open';
 
-export const help = async app => {
-  return inquirer.prompt([{
-    name: 'whereTo',
-    type: 'list',
-    message: 'Here are a few helpful resources.\n\nI will open the link you select in your browser for you',
-    choices: [{
-      name: 'Take me to the documentation',
-      value: 'http://yeoman.io/learning/'
-    }, {
-      name: 'View Frequently Asked Questions',
-      value: 'http://yeoman.io/learning/faq.html'
-    }, {
-      name: 'File an issue on GitHub',
-      value: 'http://yeoman.io/contributing/opening-issues.html'
-    }, {
-      name: 'Take me back home, Yo!',
-      value: 'home'
-    }]
-  }]).then(async answer => {
-    if (answer.whereTo === 'home') {
-      console.log('I get it, you like learning on your own. I respect that.');
-      return app.navigate('home');
-    }
+export const help = async app => inquirer.prompt([{
+  name: 'whereTo',
+  type: 'list',
+  message: 'Here are a few helpful resources.\n\nI will open the link you select in your browser for you',
+  choices: [{
+    name: 'Take me to the documentation',
+    value: 'http://yeoman.io/learning/',
+  }, {
+    name: 'View Frequently Asked Questions',
+    value: 'http://yeoman.io/learning/faq.html',
+  }, {
+    name: 'File an issue on GitHub',
+    value: 'http://yeoman.io/contributing/opening-issues.html',
+  }, {
+    name: 'Take me back home, Yo!',
+    value: 'home',
+  }],
+}]).then(async answer => {
+  if (answer.whereTo === 'home') {
+    console.log('I get it, you like learning on your own. I respect that.');
+    return app.navigate('home');
+  }
 
-    open(answer.whereTo);
-  });
-};
+  open(answer.whereTo);
+});