toWaiApp (mkDefaultMiddlewares) hardcodes `outputFormat` to wai-extra

[Javran]

I tried to change the log format by overriding makeLogger and messageLoggerSource of Yesod instance and realized there is one place sticking with its original log formatting: mkDefaultMiddlewares: note that it is hardcoded to pass outputFormat = Apache FromSocket as settings to wai-extra.

I wonder if there are existing discussions about making this more flexible (e.g. passing a custom OutputFormat)? Maybe an toWaiAppWith with a config ADT, maybe this also offers some more flexibility than having to choose between toWaiApp and toWaiAppPlain?

For those curious about workarounds, I ended up copying over implementation toWaiApp and its depdendencies to remove logWare from it, and utilize warp's setLogger instead.
Though I think keeping logWare and customizing its OutputFormat setting is also viable.

[parsonsmatt]

I agree that this is a little unsatisfying. What we've done is use toWaiAppPlain and construct all the middlewares ourselves, like you.

toWaiAppPlain itself is morally two functions: an effectful site -> IO (YesodRunnerEnv site) and a pure yreToApp :: YesodRunnerEnv site -> Application. My #1887 PR makes this separation explicit.

I am inclined to say that the default behavior should be "don't apply middlewares or anything; just build an Application and let the programmer do what they want with it." That simplifies the API a bit, at the cost of possibly having some less-convenient defaults.