Skip to content

Commit e82ab84

Browse files
authored
LRS-30 Support LRS 2.0 (#22)
* LRS-30 #comment passing LRS-2.0 branch of conformance tests in clj + cljs!!! * LRS-30 #comment remove hack for incorrect headers in tests * LRS-30 working in clj but now failing in cljs * LRS-30 proper lower casing of header to fix cljs * new version of test runner with branch selection * LRS-30 update conf test up checker * set dep back so testing w/branch works * add vscode to ignore * master branch 2.0.0 for clj sync/async * same for cljs * fix etag header validation * don't accept non-unique ids * last-mod headers for async clj * add proper conc header processing for sync state * last-mod for sync * better id check * refactored doc etag stuff * return unknown activity * recent clojure(script) and latest 2.0 xapi-schema * normalize durations prior to signed statement comparison * add test for duration norm * LRS-30 Backwards Compatibility with 1.0.x (#40) * LRS-30 backwards compatible but now fails both branches * LRS-30 fix alt syntax backwards compat, more issues remain * LRS-30 return a valid old version if specified * conditional version dispatch for doc etag behavior * test multiple versions * remove println * deps * bump tmp * correct sync doc handling * bump cljs * fix cljs multipart handling * bump ci java version * add deployment java version * use updated xapi-schema with bindable spec version * fix cljs where there are no pedestal bindings * remove TODO the unique check is good practice * collect contextAgents and contextGroups in library fns * make sure timestamp normalization uses T * also store binding version as data for use in various places * consistently derive version response header * correct interceptor order * dispatch on version for activities behavior * explicit list of supported versions * simplify context version * pass context to every method of the impl * switch conf tests back to master * release 1.4.1 of xapi-schema * reenable instrumentation on GET /about * Revert "reenable instrumentation on GET /about" This reverts commit 5118e4b. * reenable failing cljs specs in clj
1 parent 5051633 commit e82ab84

File tree

30 files changed

+857
-708
lines changed

30 files changed

+857
-708
lines changed

.github/workflows/deploy.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ jobs:
1515

1616
- name: Setup CD Environment
1717
uses: yetanalytics/action-setup-env@v2
18+
with:
19+
java-version: '21'
1820

1921
- name: Extract version
2022
id: version

.github/workflows/main.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ jobs:
2020

2121
- name: Setup CI Environment
2222
uses: yetanalytics/action-setup-env@v2
23+
with:
24+
java-version: '21'
2325

2426
- name: Run make target ${{ matrix.target }}
2527
run: make ${{ matrix.target }}

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,4 @@ package.json
2424
.clj-kondo/*
2525
!.clj-kondo/config.edn
2626
.lsp/
27+
.vscode/

deps.edn

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{:paths ["src/main" "resources"]
22
:deps
3-
{org.clojure/clojure {:mvn/version "1.10.1"}
4-
org.clojure/clojurescript {:mvn/version "1.10.741"}
3+
{org.clojure/clojure {:mvn/version "1.11.4"}
4+
org.clojure/clojurescript {:mvn/version "1.12.42"}
55
org.clojure/core.async {:mvn/version "1.5.648"}
6-
com.yetanalytics/xapi-schema {:mvn/version "1.4.0"
6+
com.yetanalytics/xapi-schema {:mvn/version "1.4.1"
77
:exclusions [org.clojure/clojurescript]}
88
com.yetanalytics/gen-openapi {:mvn/version "0.0.5"}
99
cheshire/cheshire {:mvn/version "5.10.1"}
@@ -43,7 +43,7 @@
4343
:sha "423bd6c301ce8503f5c18b43df098bbe64f8f1ab"}
4444
com.yetanalytics/lrs-test-runner
4545
{:git/url "https://github.com/yetanalytics/lrs-test-runner.git"
46-
:sha "0fcd42854f9c79a043c13d436d629826bfc5133d"}
46+
:sha "9caedae0fe5d619651f8b54fa669cec363475fef"}
4747
babashka/babashka.curl {:mvn/version "0.1.2"}}}
4848
;; bench utils for LRS implementations
4949
:bench

0 commit comments

Comments
 (0)