Skip to content

docs: update README - #2289

Merged
JuArce merged 1 commit into
testnetfrom
update_claim_docs
Jul 30, 2026
Merged

docs: update README#2289
JuArce merged 1 commit into
testnetfrom
update_claim_docs

Conversation

@JuArce

@JuArce JuArce commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@JuArce JuArce self-assigned this Jul 27, 2026
@github-actions

Copy link
Copy Markdown

Codex Code Review

No actionable security, correctness, performance, or simplicity issues found in the specified PR diff.

@claude

claude Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review

Docs-only PR (README + Makefile + config), no contract/application logic changes. Verified cross-references and they're internally consistent:

  • config.base-mainnet.json matches the /script-config/config.<name>.json path pattern read by DeployClaimableAirdrop.s.sol.
  • tokenProxy in config.mainnet.json (0x50614CC8e44F7814549c223aA31db9296e58057c) and the new config.base-mainnet.json (0x53f39e5C53EE40bbc3Da97C3B47BD2968d110a8D) match the canonical addresses in base/README.md's "Deployed Addresses" table (case differences only, same address).
  • L1_BRIDGE_MAINNET address quoted in the new "From a safe" section (0x3154Cf16ccdb4C6d922629664174b904d80F2C35) matches base/.env.example.
  • deploy-token-mainnet/deploy-claimable-mainnet/new deploy-claimable-base-mainnet consistently switch from --keystore $(KEYSTORE_PATH) to --interactive, and KEYSTORE_PATH is fully removed (no dangling references left).
  • calldata-approve-spending now takes $(APPROVE_AMOUNT) instead of a hardcoded value; the variable already has a sane default (2600000000000000000000000000) defined earlier in the Makefile, so existing invocations without the override keep working.

No security, correctness, or performance issues found — this is a straightforward, well cross-checked documentation update for the Base mainnet claim flow.

Minor nit (non-blocking): the Makefile diff introduces a doubled blank line between the new deploy-claimable-base-mainnet target and the TODO comment below it.

@JuArce
JuArce merged commit 6efdbff into testnet Jul 30, 2026
5 checks passed
@JuArce
JuArce deleted the update_claim_docs branch July 30, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants