Skip to content

Commit bce22e0

Browse files
authored
Only use create_element_ns if needed (#3970)
fixes invisible svg on chrome when included with unchecked html
1 parent 2019f45 commit bce22e0

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

packages/yew/src/dom_bundle/braw.rs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,13 @@ pub struct BRaw {
1616

1717
impl BRaw {
1818
fn create_elements(html: &str, parent_namespace: Option<&str>) -> Vec<Node> {
19-
let div = gloo::utils::document()
20-
.create_element_ns(parent_namespace, "div")
21-
.unwrap();
19+
let div = if parent_namespace.is_some() {
20+
gloo::utils::document()
21+
.create_element_ns(parent_namespace, "div")
22+
.unwrap()
23+
} else {
24+
gloo::utils::document().create_element("div").unwrap()
25+
};
2226
div.set_inner_html(html);
2327
let children = div.child_nodes();
2428
let children = js_sys::Array::from(&children);

0 commit comments

Comments
 (0)