Add target to <Link />

[nuzzles]

I'd like to discuss adding a target prop to the Yew router Link, with potential to have a ctrl+click target as well. Do we have conflicting opinions on API or can this be a straightforward implementation?

<Link<Route> target="_self" ctrl_target="_blank" to={*route}/>

[WorldSEnder]

As far as I am aware, Shift+click always opens in a new window, and Ctrl+click always opens in a new tab, both in Firefox and Chrome, for a normal <a> link. I don't know of any user setting that changes this.

That being assumed, I wouldn't make this configurable to something else. The expected UX is the default behaviour, adding an override via some ctrl_target or shift_target props is not necessary imo.

Something I'm less aware of is how keyboard navigation is handled for a normal link, it could be convenient to add this to (or open a follow up issue to track it).

[nuzzles]

I see your points, they're valid (honestly had no idea that is behavior set by Chrome/FF).

However perhaps there's still value in changing the default target?
<Link<Route> target="_blank" to={*route}/>

I could see someone wanting to ensure their link always opens a new tab.

[WorldSEnder]

I agree, target="_blank" has its value. A central question though: should target="_self" be allowed and would this skip the history API? I suppose so, since (1) it could be a way to bypass the navigator and go straight to the browser (2) special handling would be hard to get right. For example target="_parent" also falls back to _self if there is no parent, further named windows are a thing and the reason target should still probably be stringly typed.

It's also precdented by Angular

[nuzzles]

e.g. You want target to be of an Enum type, (e.g. target={Target::Blank}) not presented as a string, such that it doesn't conflict with the navigator?

[WorldSEnder]

I'd make it an optional but stringly typed attribute. If it is present, skip the navigator and invoke window.open(href, target). Otherwise go through the configured navigator from the context (present behaviour).

[nuzzles]

I'll try to get this done today.

[nuzzles]

PR is up: #2782

I will wait to add tests after review, or if someone else wants to write tests, that is okay too.