-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Open
Labels
A-ciArea: The continuous integrationArea: The continuous integrationA-toolsArea: Tools such as trunk, wasm-bindgenArea: Tools such as trunk, wasm-bindgenmetaRepository chores and tasksRepository chores and tasks
Description
This issue aims to improve GitHub Action Workflows.
Testing Workflow
Currently, some tests are not executed in the Workflow & cargo make pr-flow (and they are actually broken / does not work if you try to run them).
Related: #2403.
test dom_bundle::btag::tests_without_browser::html_if_bool ... FAILED
test dom_bundle::btag::tests_without_browser::html_if_option ... FAILED
- Properly gate all wasm and non-wasm tests so that
cargo testcan work & update workflow so thatcargo testis run as well. - Unify how tests are run on both local and CI (by adapting cargo-make?), or remove local-based flow (as pointed out here).
Website and API docs Workflow
If the Website and API docs workflow both meets the condition to be run on a pull request, the latter one will override the comment of the one completed first.
- Give the action a way to differentiate comments of each other (maybe a title?)
Benchmark Workflow
Currently, benchmark result in a comment posted on every commit while a pull request is open and a comment on every merge commit.
- Only run if the pull request modifies the actual code (
packages/*ortools/*) - Edit existing comments if one is present
- Omit the comment on master branch after merging
Size Comparison Workflow
- Make the comment collapsable
- Show build system information (version of rust, wasm-bindgen, etc.) and commit ref
- Show difference in percentage as well
- Show a summary and warns if any example has received a substantial increase.
voidpumpkin
Metadata
Metadata
Assignees
Labels
A-ciArea: The continuous integrationArea: The continuous integrationA-toolsArea: Tools such as trunk, wasm-bindgenArea: Tools such as trunk, wasm-bindgenmetaRepository chores and tasksRepository chores and tasks
