Skip to content

Improve Workflows #2541

@futursolo

Description

@futursolo

This issue aims to improve GitHub Action Workflows.

Testing Workflow

Currently, some tests are not executed in the Workflow & cargo make pr-flow (and they are actually broken / does not work if you try to run them).

Related: #2403.

test dom_bundle::btag::tests_without_browser::html_if_bool ... FAILED
test dom_bundle::btag::tests_without_browser::html_if_option ... FAILED
  • Properly gate all wasm and non-wasm tests so that cargo test can work & update workflow so that cargo test is run as well.
  • Unify how tests are run on both local and CI (by adapting cargo-make?), or remove local-based flow (as pointed out here).

Website and API docs Workflow

If the Website and API docs workflow both meets the condition to be run on a pull request, the latter one will override the comment of the one completed first.

image

  • Give the action a way to differentiate comments of each other (maybe a title?)

Benchmark Workflow

Currently, benchmark result in a comment posted on every commit while a pull request is open and a comment on every merge commit.

  1. Only run if the pull request modifies the actual code (packages/* or tools/*)
  2. Edit existing comments if one is present
  3. Omit the comment on master branch after merging

Size Comparison Workflow

  1. Make the comment collapsable
  2. Show build system information (version of rust, wasm-bindgen, etc.) and commit ref
  3. Show difference in percentage as well
  4. Show a summary and warns if any example has received a substantial increase.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ciArea: The continuous integrationA-toolsArea: Tools such as trunk, wasm-bindgenmetaRepository chores and tasks

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions