Fix bug where ephemeral links would try to reconnect in a fast loop

neilalexander · neilalexander · commit d1b849588f1d · 2024-09-29T21:24:39.000+01:00
Helps #1141, although not a complete solution.
diff --git a/src/core/link.go b/src/core/link.go
@@ -359,8 +359,9 @@ func (l *links) add(u *url.URL, sintf string, linkType linkType) error {
 					if backoffNow() {
 						continue
 					}
-					return
 				}
+				// Ephemeral or incoming connections don't reconnect.
+				return
 			}
 		}()
 	})

Original file line number	Diff line number	Diff line change
`@@ -359,8 +359,9 @@ func (l links) add(u url.URL, sintf string, linkType linkType) error {`
`359`	`359`	`if backoffNow() {`
`360`	`360`	`continue`
`361`	`361`	`}`
`362`		`- return`
`363`	`362`	`}`
	`363`	`+ // Ephemeral or incoming connections don't reconnect.`
	`364`	`+ return`
`364`	`365`	`}`
`365`	`366`	`}()`
`366`	`367`	`})`