Skip to content

Commit b75e62b

Browse files
authored
[EDR Worfklows][FF Cleanup] Remove eventCollectionDataReductionBannerEnabled feature flag (elastic#239576)
## Summary This PR removes the `eventCollectionDataReductionBannerEnabled` feature flag, which has been enabled by default. The event collection data reduction banner functionality is now permanently available. ## Changes ### Source Files **policy_settings_form.tsx** - Removed `useIsExperimentalFeatureEnabled('eventCollectionDataReductionBannerEnabled')` hook call - Simplified banner visibility logic to only rely on browser storage (`securitySolution.showEventMergingBanner`) - The Event Merging Banner now always shows by default on first visit and can be permanently dismissed by users ### Test Files **policy_settings_form.test.tsx** - Replaced feature flag mocks with storage mocks for banner visibility control - Removed obsolete test case for feature flag disabled state - Updated test setup to use `storageMock.set()` instead of `setExperimentalFlag()` ### Configuration **experimental_features.ts** - Removed `eventCollectionDataReductionBannerEnabled` flag definition ## Behavior After This Change - The Event Merging Banner will be shown by default to all users who haven't previously dismissed it - Users can dismiss the banner, and this preference is stored in browser storage - No feature flag check is performed - the feature is always enabled
1 parent 35108e8 commit b75e62b

3 files changed

Lines changed: 3 additions & 19 deletions

File tree

x-pack/solutions/security/plugins/security_solution/common/experimental_features.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,6 @@ export const allowedExperimentalValues = Object.freeze({
200200
*/
201201
responseActionsMSDefenderEndpointEnabled: true,
202202

203-
/**
204-
* Enables banner for informing users about changes in data collection.
205-
*/
206-
eventCollectionDataReductionBannerEnabled: true,
207-
208203
/** Enables new Data View Picker */
209204
newDataViewPickerEnabled: true,
210205

x-pack/solutions/security/plugins/security_solution/public/management/pages/policy/view/policy_settings_form/policy_settings_form.test.tsx

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,23 +51,16 @@ describe('Endpoint Policy Settings Form', () => {
5151
'data-test-subj': 'test',
5252
};
5353

54-
mockedContext.setExperimentalFlag({ eventCollectionDataReductionBannerEnabled: false });
54+
storageMock.set('securitySolution.showEventMergingBanner', false);
5555

5656
render = () => (renderResult = mockedContext.render(<PolicySettingsForm {...formProps} />));
5757
});
5858

5959
describe('event merging banner', () => {
6060
beforeEach(() => {
61-
mockedContext.setExperimentalFlag({ eventCollectionDataReductionBannerEnabled: true });
61+
storageMock.set('securitySolution.showEventMergingBanner', true);
6262
});
6363

64-
it('should hide the banner if its not allowed to be displayed', () => {
65-
mockedContext.setExperimentalFlag({ eventCollectionDataReductionBannerEnabled: false });
66-
67-
render();
68-
69-
expect(renderResult.queryByTestId('eventMergingCallout')).not.toBeInTheDocument();
70-
});
7164
it('should show the event merging banner if it has never been dismissed', () => {
7265
render();
7366

x-pack/solutions/security/plugins/security_solution/public/management/pages/policy/view/policy_settings_form/policy_settings_form.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ export const PolicySettingsForm = memo<PolicySettingsFormProps>((props) => {
4949

5050
const { storage } = useKibana().services;
5151

52-
const eventCollectionDataReductionBannerEnabled = useIsExperimentalFeatureEnabled(
53-
'eventCollectionDataReductionBannerEnabled'
54-
);
5552
const trustedDevices = useIsExperimentalFeatureEnabled('trustedDevices');
5653

5754
const renderDeviceControlSection = () => {
@@ -72,8 +69,7 @@ export const PolicySettingsForm = memo<PolicySettingsFormProps>((props) => {
7269
};
7370

7471
const [showEventMergingBanner, setShowEventMergingBanner] = useState(
75-
eventCollectionDataReductionBannerEnabled &&
76-
(storage.get('securitySolution.showEventMergingBanner') ?? true)
72+
storage.get('securitySolution.showEventMergingBanner') ?? true
7773
);
7874
const onBannerDismiss = useCallback(() => {
7975
setShowEventMergingBanner(false);

0 commit comments

Comments
 (0)