Commit b75e62b
authored
[EDR Worfklows][FF Cleanup] Remove eventCollectionDataReductionBannerEnabled feature flag (elastic#239576)
## Summary
This PR removes the `eventCollectionDataReductionBannerEnabled` feature
flag, which has been enabled by default. The event collection data
reduction banner functionality is now permanently available.
## Changes
### Source Files
**policy_settings_form.tsx**
- Removed
`useIsExperimentalFeatureEnabled('eventCollectionDataReductionBannerEnabled')`
hook call
- Simplified banner visibility logic to only rely on browser storage
(`securitySolution.showEventMergingBanner`)
- The Event Merging Banner now always shows by default on first visit
and can be permanently dismissed by users
### Test Files
**policy_settings_form.test.tsx**
- Replaced feature flag mocks with storage mocks for banner visibility
control
- Removed obsolete test case for feature flag disabled state
- Updated test setup to use `storageMock.set()` instead of
`setExperimentalFlag()`
### Configuration
**experimental_features.ts**
- Removed `eventCollectionDataReductionBannerEnabled` flag definition
## Behavior After This Change
- The Event Merging Banner will be shown by default to all users who
haven't previously dismissed it
- Users can dismiss the banner, and this preference is stored in browser
storage
- No feature flag check is performed - the feature is always enabled1 parent 35108e8 commit b75e62b
3 files changed
Lines changed: 3 additions & 19 deletions
File tree
- x-pack/solutions/security/plugins/security_solution
- common
- public/management/pages/policy/view/policy_settings_form
Lines changed: 0 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | 203 | | |
209 | 204 | | |
210 | 205 | | |
| |||
Lines changed: 2 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | 64 | | |
72 | 65 | | |
73 | 66 | | |
| |||
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | 52 | | |
56 | 53 | | |
57 | 54 | | |
| |||
72 | 69 | | |
73 | 70 | | |
74 | 71 | | |
75 | | - | |
76 | | - | |
| 72 | + | |
77 | 73 | | |
78 | 74 | | |
79 | 75 | | |
| |||
0 commit comments