Swap without a query

[halo3mic]

The current version of YakRouter swap queries all adapters for their amounts before swapping. This ensures the correct amounts are used for swaps and saves user gas if the final amount-out is below the minimum amount-out specified by the user.

The queries however can be quite gas-intensive, for example:

• Querying Gondola DAI-ZDAI pool through adapter costs 84340 gas
• Querying Snob S3 pool through the adapter to swap DAI for USDT costs 99130 gas
• Querying Unilike pool through the adapter to swap DAI to WAVAX costs 13612 gas

To avoid such high gas costs queries could be removed and the swap amount for the next step could be derived from the token balance in the adapter. ER20.balanceOf costs 23k, so the gas reduction would be substantial.

The big downside of this approach is that if price moved on the user to the point that the trade would fail. Now the trade would fail with relatively low gas cost after all the queries are completed, but with this approach, trade would fail in the last step costing the user substantially more gas.

[snow-farmer]

Recently on the router, about 4% of trades fail. We can now do the math for identifying which is better for users.

https://cchain.explorer.avax.network/address/0x187Cd11549a20ACdABd43992d01bfcF2Bfc3E18d/transactions

[snow-farmer]

Adding a low slippage (0.2%) the failure rate has become closer to zero.

[snow-farmer]

We could include both ways and let front-ends solve. For example, low slippage trades (higher chance to fail) should use the method which consumes less gas in revert scenarios and high slippage trades (lower chance to fail) should use the method which consumes less gas in success scenarios.

[halo3mic]

We could include both ways and let front-ends solve. For example, low slippage trades (higher chance to fail) should use the method which consumes less gas in revert scenarios and high slippage trades (lower chance to fail) should use the method which consumes less gas in success scenarios.

That is a really good idea!

[RedWilly]

Hey i have a question how do i get the amount out of when using findBestPath it provides the the path, amountin and not out

[halo3mic]

Hey i have a question how do i get the amount out of when using findBestPath it provides the the path, amountin and not out

Method findBestPath returns object of type FormattedOffer. There is parameter amounts in this object, an array that contains input amount, all intermediate amounts (in case of >1 hops) and output amount. Output amount is the last element of the amounts array.

[RicqCodes]

@halo3mic, I'm really struggling here and could use your help.

1. I've been using the findBestPathWithGas function, and it correctly returns the FormattedOffer object needed for swapNoSplit. However, I'm facing a recurring issue: when I set it to 3 steps, it sometimes uses multiple adapters, and I frequently encounter an insufficient amount-out error from the pair contract. But if I reduce the steps to 2, the swap transaction seems to go through without any issues. It's quite perplexing and frustrating.

2. Also, when dealing with tokens that have known fees, I keep getting the same insufficient amount-out error, no matter how I adjust the amountOut, even setting it to 0. It just doesn’t seem to work at all.

The router is deployed on base blockchain at 0xC448CCD732085891c3B2E819FED09ad3C4C39509, and the token I’m trying to swap is called frenpet, at 0xFF0C532FDB8Cd566Ae169C1CB157ff2Bdc83E105. Interestingly, using BaseSwap for the same token swap works with 5% slippage which is where liquidity was created. I have baseswap v2, uniswap v2 & v3, sushiswap v2, pancakeswap v2 & v3 deployed as adapters.

Any advice or pointers you could provide would be greatly appreciated. I'm really lost.

[RedWilly]

@halo3mic, I'm really struggling here and could use your help.

1. I've been using the findBestPathWithGas function, and it correctly returns the FormattedOffer object needed for swapNoSplit. However, I'm facing a recurring issue: when I set it to 3 steps, it sometimes uses multiple adapters, and I frequently encounter an insufficient amount-out error from the pair contract. But if I reduce the steps to 2, the swap transaction seems to go through without any issues. It's quite perplexing and frustrating.
2. Also, when dealing with tokens that have known fees, I keep getting the same insufficient amount-out error, no matter how I adjust the amountOut, even setting it to 0. It just doesn’t seem to work at all.

The router is deployed on base blockchain at 0xC448CCD732085891c3B2E819FED09ad3C4C39509, and the token I’m trying to swap is called frenpet, at 0xFF0C532FDB8Cd566Ae169C1CB157ff2Bdc83E105. Interestingly, using BaseSwap for the same token swap works with 5% slippage which is where liquidity was created. I have baseswap v2, uniswap v2 & v3, sushiswap v2, pancakeswap v2 & v3 deployed as adapters.

Any advice or pointers you could provide would be greatly appreciated. I'm really lost.

I also did get the exact same issue. I posted it in the telegram dev community but got no helpful response on how to deal with that. Was even hoping to take a look at how the handle it on the front end part but nothing.

Anyways if you somehow ever found an issue please tag me.

[RicqCodes]

@halo3mic, I'm really struggling here and could use your help.

1. I've been using the findBestPathWithGas function, and it correctly returns the FormattedOffer object needed for swapNoSplit. However, I'm facing a recurring issue: when I set it to 3 steps, it sometimes uses multiple adapters, and I frequently encounter an insufficient amount-out error from the pair contract. But if I reduce the steps to 2, the swap transaction seems to go through without any issues. It's quite perplexing and frustrating.
2. Also, when dealing with tokens that have known fees, I keep getting the same insufficient amount-out error, no matter how I adjust the amountOut, even setting it to 0. It just doesn’t seem to work at all.

The router is deployed on base blockchain at 0xC448CCD732085891c3B2E819FED09ad3C4C39509, and the token I’m trying to swap is called frenpet, at 0xFF0C532FDB8Cd566Ae169C1CB157ff2Bdc83E105. Interestingly, using BaseSwap for the same token swap works with 5% slippage which is where liquidity was created. I have baseswap v2, uniswap v2 & v3, sushiswap v2, pancakeswap v2 & v3 deployed as adapters.
Any advice or pointers you could provide would be greatly appreciated. I'm really lost.

I also did get the exact same issue. I posted it in the telegram dev community but got no helpful response on how to deal with that. Was even hoping to take a look at how the handle it on the front end part but nothing.

Anyways if you somehow ever found an issue please tag me.

I'm hoping to find solution, if you could share the telegram channel i'd appreciate that.

[RicqCodes]

@RedWilly I think I found out why, took a while to debug!

[RedWilly]

Okay can you share your finding