Remove compile_against option from JvmLibraryArg

Summary: We don't want to give libraries the choice of which version of their dependencies they actually build against.

Reviewed By: mykola-semko

fbshipit-source-id: da8a6225316a7b7bfb199e0d08c359cb314086d6

Author: IanChilds

src/com/facebook/buck/jvm/java/DefaultJavaLibraryClasspaths.java

@@ -123,12 +123,7 @@ public ImmutableList<JavaDependencyInfo> getDependencyInfosForSourceOnlyAbi() {
   private BuildRule getAbiDep(BuildRule compileTimeFullDep) {
     Preconditions.checkState(compileTimeFullDep instanceof HasJavaAbi);
     HasJavaAbi hasJavaAbi = (HasJavaAbi) compileTimeFullDep;
-    CompileAgainstLibraryType compileAgainstLibraryType = getCompileAgainstLibraryType();
-    Optional<BuildTarget> abiJarTarget = Optional.empty();
-
-    if (compileAgainstLibraryType.equals(CompileAgainstLibraryType.SOURCE_ONLY_ABI)) {
-      abiJarTarget = hasJavaAbi.getSourceOnlyAbiJar();
-    }
+    Optional<BuildTarget> abiJarTarget = hasJavaAbi.getSourceOnlyAbiJar();
 
     if (!abiJarTarget.isPresent()) {
       abiJarTarget = hasJavaAbi.getAbiJar();

src/com/facebook/buck/jvm/java/DefaultJavaLibraryRules.java

@@ -674,17 +674,9 @@ private JavacPluginParams abiProcessorsOnly(
 
   @Value.Lazy
   CompileAgainstLibraryType getCompileAgainstLibraryType() {
-    CoreArg args = getArgs();
-    CompileAgainstLibraryType result = CompileAgainstLibraryType.SOURCE_ONLY_ABI;
-    if (args != null) {
-      result = args.getCompileAgainst().orElse(result);
-    }
-
-    if (!getConfiguredCompilerFactory().shouldCompileAgainstAbis()) {
-      result = CompileAgainstLibraryType.FULL;
-    }
-
-    return result;
+    return getConfiguredCompilerFactory().shouldCompileAgainstAbis()
+        ? CompileAgainstLibraryType.ABI
+        : CompileAgainstLibraryType.FULL;
   }
 
   @Value.Lazy

src/com/facebook/buck/jvm/java/JvmLibraryArg.java

@@ -74,8 +74,6 @@ public interface JvmLibraryArg extends BuildRuleArg, MaybeRequiredForSourceOnlyA
 
   Optional<AbiGenerationMode> getAbiGenerationMode();
 
-  Optional<CompileAgainstLibraryType> getCompileAgainst();
-
   Optional<SourceAbiVerificationMode> getSourceAbiVerificationMode();
 
   Optional<UnusedDependenciesParams.UnusedDependenciesAction> getOnUnusedDependencies();