Unsupported operand types: int + string

[nadar]

From time to time sentry logs this error: Unsupported operand types: int + string

Stacktrace:

$payload = $this->redis->hget("$this->channel.messages", $id);
list($ttr, $message) = explode(';', $payload, 2);
$this->redis->zadd("$this->channel.reserved", time() + $ttr, $id);

https://github.com/yiisoft/yii2-queue/blob/master/src/drivers/redis/Queue.php#L160

For whatever reason $ttr seems to be a string instead of an int. Should we maybe typecast $ttr or throw an exception?

[samdark]

Yes. Let's typecast it.

[samdark]

Would you please create a pull request? Thanks.

[rob006]

PHP should not complain about numerical strings in this case. You will get such error when you try something like time() + "abcd". Typecast wil result 0 in this case, and it will only hide bug in other place, that resulted invalid ttr.

What is the value of $ttr when you have such error?

[nadar]

@rob006 sadly i can not say what is the value, we see it from time to time in sentry and those values are not logged - but it seems to be an issue somehow and typecast won't hurt? so can i send a PR or not?

[nadar]

[rob006]

and typecast won't hurt?

It may hurt, if value is not a number - then it will be silently casted to 0 and this is not something you want. Cast will only hide real error (invalid ttr) in that case.

[nadar]

can we throw a better exception then? if (!is_number($ttr)) { throw new ....

[samdark]

@nadar yes. Better exception is an excellent idea.