2.0.18 added support for scheme tls in f96b872
That adapts the connection string to tls:// instead of tcp://.
BUT we already had useSSL.
Imho there's a bunch of problems with having two options for kinda the same thing.
- what happens if I set scheme to
tls and useSSL to true? will the stream_socket_client() magically enable TLS but the useSSL do it again via stream_socket_enable_crypto()? Or will it throw an error?
useSSL => true should probably also switch the scheme in the connectionString, as that is a public getter/property- it's just plain confusing with two options
2.0.18 added support for
schemetlsin f96b872That adapts the connection string to
tls://instead oftcp://.BUT we already had
useSSL.Imho there's a bunch of problems with having two options for kinda the same thing.
tlsanduseSSLto true? will thestream_socket_client()magically enable TLS but theuseSSLdo it again viastream_socket_enable_crypto()? Or will it throw an error?useSSL => trueshould probably also switch the scheme in theconnectionString, as that is a public getter/property