test(onboard): cover all messaging channels and edge cases for preset merge (NVIDIA#5967)

The NVIDIA#5967 fix is channel-agnostic — it iterates the channel→preset
registry — but unit coverage only exercised Slack and Discord. Add
explicit merge cases for Telegram, Teams, WhatsApp, and WeChat, prune
cases for WhatsApp/WeChat, and edge cases for an empty/null/undefined
channel list (selection unchanged) and an unknown channel name (no
preset), so a future channel-table regression cannot pass on the two
already-covered channels alone.

Signed-off-by: Yimo Jiang <yimoj@nvidia.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: yimoj

src/lib/onboard/messaging-policy-presets.test.ts

@@ -7,8 +7,8 @@ import {
   allMessagingChannelPolicyPresets,
   hasDisabledMessagingPolicyPreset,
   mergeAppliedPolicyPresetsForDisabledMessagingCleanup,
+  mergeEnabledMessagingChannelPolicyPresets,
   mergePolicyMessagingChannels,
-  mergeRequiredMessagingChannelPolicyPresets,
   pruneDisabledMessagingPolicyPresets,
   requiredMessagingChannelPolicyPresets,
 } from "./messaging-policy-presets";
@@ -20,7 +20,7 @@ describe("messaging policy presets", () => {
   });
 
   it("merges required messaging presets into an existing selection", () => {
-    expect(mergeRequiredMessagingChannelPolicyPresets(["npm", "pypi"], ["slack"])).toEqual([
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm", "pypi"], ["slack"])).toEqual([
       "npm",
       "pypi",
       "slack",
@@ -31,24 +31,24 @@ describe("messaging policy presets", () => {
   // WhatsApp, Teams, WeChat) still needs its egress preset merged so policy
   // finalization persists it and policy-list marks it applied.
   it("merges an enabled channel preset that is not required at create time", () => {
-    expect(mergeRequiredMessagingChannelPolicyPresets(["npm"], ["discord"])).toEqual([
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm"], ["discord"])).toEqual([
       "npm",
       "discord",
     ]);
     expect(requiredMessagingChannelPolicyPresets(["discord"])).toEqual([]);
-    expect(mergeRequiredMessagingChannelPolicyPresets(["npm"], ["slack", "discord"])).toEqual([
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm"], ["slack", "discord"])).toEqual([
       "npm",
       "slack",
       "discord",
     ]);
   });
 
   it("does not add a channel preset that is not available to the sandbox", () => {
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm"], ["slack"], new Set(["npm"]))).toEqual(
+      ["npm"],
+    );
     expect(
-      mergeRequiredMessagingChannelPolicyPresets(["npm"], ["slack"], new Set(["npm"])),
-    ).toEqual(["npm"]);
-    expect(
-      mergeRequiredMessagingChannelPolicyPresets(["npm"], ["discord"], new Set(["npm"])),
+      mergeEnabledMessagingChannelPolicyPresets(["npm"], ["discord"], new Set(["npm"])),
     ).toEqual(["npm"]);
   });
 
@@ -108,4 +108,40 @@ describe("messaging policy presets", () => {
       mergeAppliedPolicyPresetsForDisabledMessagingCleanup(["npm"], ["npm", "github"], ["slack"]),
     ).toEqual(["npm"]);
   });
+
+  // #5967 is channel-agnostic: every non-`requiredAtCreate` channel (Telegram,
+  // Teams, WhatsApp, WeChat) must merge and prune exactly like Discord. Cover the
+  // remaining channels explicitly so a future channel-table regression cannot pass
+  // on Slack/Discord alone.
+  it("merges every enabled non-required channel preset, not just Slack and Discord (#5967)", () => {
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm"], ["telegram"])).toEqual([
+      "npm",
+      "telegram",
+    ]);
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm"], ["teams"])).toEqual(["npm", "teams"]);
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm"], ["whatsapp"])).toEqual([
+      "npm",
+      "whatsapp",
+    ]);
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm"], ["wechat"])).toEqual([
+      "npm",
+      "wechat",
+    ]);
+  });
+
+  it("prunes every disabled non-required channel preset (#5967)", () => {
+    expect(pruneDisabledMessagingPolicyPresets(["npm", "whatsapp"], ["whatsapp"])).toEqual(["npm"]);
+    expect(pruneDisabledMessagingPolicyPresets(["npm", "wechat"], ["wechat"])).toEqual(["npm"]);
+  });
+
+  it("leaves the selection untouched when no channels are enabled (#5967)", () => {
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm"], [])).toEqual(["npm"]);
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm"], null)).toEqual(["npm"]);
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm"], undefined)).toEqual(["npm"]);
+  });
+
+  it("yields no preset for an unknown channel name (#5967)", () => {
+    expect(allMessagingChannelPolicyPresets(["nonexistent"])).toEqual([]);
+    expect(mergeEnabledMessagingChannelPolicyPresets(["npm"], ["nonexistent"])).toEqual(["npm"]);
+  });
 });