Allow register_output_helper to mark output safe before call to raw (#303)

Author: z1lk

lib/phlex/rails/helper_macros.rb

@@ -2,7 +2,7 @@
 
 module Phlex::Rails::HelperMacros
 	# Register a Rails helper that returns safe HTML to be pushed to the output buffer.
-	def register_output_helper(method_name)
+	def register_output_helper(method_name, mark_safe: false)
 		class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
 			# frozen_string_literal: true
 
@@ -13,7 +13,7 @@ def #{method_name}(*args, **kwargs, &block)
 					view_context.#{method_name}(*args, **kwargs)
 				end
 
-				raw(output)
+				raw(#{mark_safe ? 'safe(output)' : 'output'})
 			end
 		RUBY
 	end

test/helper_macros.test.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+test "register_output_helper with raw marked safe" do
+	view_ctx = ActionController::Base.new.view_context
+	view_ctx.define_singleton_method(:raw_html_producing_method) { "<span>ok</span>" }
+
+	component = Class.new(Phlex::HTML) do
+		register_output_helper :raw_html_producing_method, mark_safe: true
+
+		def view_template
+			div { raw_html_producing_method }
+		end
+	end
+
+	assert_equivalent_html component.render_in(view_ctx), "<div><span>ok</span></div>"
+end
+
+test "register_output_helper with raw not marked safe (default)" do
+	view_ctx = ActionController::Base.new.view_context
+	view_ctx.define_singleton_method(:raw_html_producing_method) { "<span>ok</span>" }
+
+	component = Class.new(Phlex::HTML) do
+		register_output_helper :raw_html_producing_method
+
+		def view_template
+			div { raw_html_producing_method }
+		end
+	end
+
+	error = assert_raises Phlex::ArgumentError do
+		component.render_in(view_ctx)
+	end
+	assert_equal error.message, "You passed an unsafe object to `raw`."
+end