Handle more literal types in static attributes

Author: joeldrapper

lib/phlex/compiler/method_compiler.rb

@@ -73,8 +73,11 @@ def compile_standard_element(node, tag)
 
 		def visit_phlex_attributes(node)
 			if node.arguments in [Prism::KeywordHashNode[elements: attributes]]
-				result = attributes.all? { |attribute| attribute in Prism::AssocNode[key: Prism::SymbolNode, value: Prism::StringNode] }
-				if result
+				literal_attributes = attributes.all? do |attribute|
+					Prism::AssocNode === attribute && static_attribute_value_literal?(attribute)
+				end
+
+				if literal_attributes
 					return buffer(Phlex::SGML::Attributes.generate_attributes(eval("{#{node.slice}}")))
 				end
 			end
@@ -147,7 +150,7 @@ def compile_interpolated_string_node(node)
 						buffer(").to_s)}"),
 					]
 				else
-				  raise Phlex::Compiler::Error, "Unexpected node type in InterpolatedStringNode: #{part.class}"
+					raise Phlex::Compiler::Error, "Unexpected node type in InterpolatedStringNode: #{part.class}"
 				end
 			end
 		end
@@ -309,6 +312,38 @@ def compile_raw_helper(node)
 			end
 		end
 
+		private def static_attribute_value_literal?(value)
+			case value
+			when Prism::SymbolNode, Prism::StringNode, Prism::IntegerNode, Prism::FloatNode, Prism::TrueNode, Prism::FalseNode, Prism::NilNode
+				true
+			when Prism::ArrayNode
+				value.elements.all? { |n| static_token_value_literal?(n) }
+			when Prism::HashNode
+				value.elements.all? { |n| static_attribute_value_literal?(n) }
+			when Prism::AssocNode
+				(Prism::StringNode === value.key || Prism::SymbolNode === value.key) && static_attribute_value_literal?(value.value)
+			when Prism::CallNode
+				if value in { receiver: Prism::ConstantReadNode[name: :Set]| Prism::ConstantPathNode[name: :Set, parent: nil], name: :[] }
+					value.arguments.arguments.all? { |n| static_token_value_literal?(n) }
+				else
+					false
+				end
+			else
+				false
+			end
+		end
+
+		private def static_token_value_literal?(value)
+			case value
+			when Prism::SymbolNode, Prism::StringNode, Prism::IntegerNode, Prism::FloatNode, Prism::NilNode
+				true
+			when Prism::ArrayNode
+				value.elements.all? { |n| static_token_value_literal?(n) }
+			else
+				false
+			end
+		end
+
 		private def whitespace_helper?(node)
 			node.name == :whitespace && own_method_without_scope?(node)
 		end

quickdraw/compilation_equivalence_cases/attributes.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+class Attributes < Phlex::HTML
+	def view_template
+		div(
+			a: nil,
+			b: 1,
+			c: :two,
+			d: "three",
+			e: 4.5,
+			f: false,
+			g: true,
+			h: [nil, 1, :two, "three", 4.5, [1]],
+			i: Set[nil, 1, :two, "three", 4.5, [1]],
+			j: {
+				k: 1,
+				"l" => 2
+			},
+			"m" => 3
+		)
+	end
+end