Fix potential issues reported by PHPStan and PHPCS

Author: jissereitsma

.module.ini

@@ -2,3 +2,5 @@ EXTENSION_VENDOR="Yireo"
 EXTENSION_NAME="ExtensionChecker"
 COMPOSER_NAME="yireo/magento2-extensionchecker"
 PHP_VERSIONS=("8.1", "8.2", "8.3","8.4")
+PHPSTAN_LEVEL=1
+PHPCS_SEVERITY=9

ComponentCollector/AbstractComponentCollector.php

@@ -2,8 +2,6 @@
 
 namespace Yireo\ExtensionChecker\ComponentCollector;
 
-use Magento\Framework\Exception\FileSystemException;
-use Magento\Framework\Exception\NotFoundException;
 use Yireo\ExtensionChecker\Component\Component;
 use Yireo\ExtensionChecker\Component\ComponentFactory;
 use Yireo\ExtensionChecker\PhpClass\ComponentCollector;
@@ -26,9 +24,8 @@ public function __construct(
 
     /**
      * @param string $content
+     * @param bool $hardRequirement
      * @return Component[]
-     * @throws FileSystemException
-     * @throws NotFoundException
      */
     protected function findComponentsByModuleName(string $content, bool $hardRequirement = false): array
     {
@@ -47,9 +44,8 @@ protected function findComponentsByModuleName(string $content, bool $hardRequire
 
     /**
      * @param string $content
+     * @param bool $hardRequirement
      * @return Component[]
-     * @throws FileSystemException
-     * @throws NotFoundException
      */
     protected function findComponentsByClassName(string $content, bool $hardRequirement = false): array
     {
@@ -79,9 +75,8 @@ protected function findComponentsByClassName(string $content, bool $hardRequirem
     /**
      * @param string $contents
      * @param array $patterns
+     * @param bool $hardRequirement
      * @return Component[]
-     * @throws FileSystemException
-     * @throws NotFoundException
      */
     protected function findComponentsByPattern(string $contents, array $patterns, bool $hardRequirement = false): array
     {

ComponentCollector/TemplateComponentCollector.php

@@ -24,7 +24,7 @@ public function __construct(
 
     /**
      * @param string $file
-     * @return Component
+     * @return Component[]
      * @throws FileSystemException
      * @throws NotFoundException
      */

ComponentDetector/ComponentDetectorInterface.php

@@ -8,7 +8,7 @@ interface ComponentDetectorInterface
 {
     /**
      * @param string $moduleName
-     * @return Component
+     * @return Component[]
      */
     public function getComponentsByModuleName(string $moduleName): array;
 }

ComponentDetector/ComponentDetectorList.php

@@ -48,7 +48,7 @@ public function getComponentsByModuleName(string $moduleName): array
 
     /**
      * @param Component[] $components
-     * @return void
+     * @return Component[]
      */
     private function filterSoftAndHardDuplicates(array $components): array
     {

ComponentDetector/JsComponentDetector.php

@@ -11,7 +11,7 @@ class JsComponentDetector implements ComponentDetectorInterface
 {
     /**
      * @param string $moduleName
-     * @return Component
+     * @return Component[]
      */
     public function getComponentsByModuleName(string $moduleName): array
     {

ComponentDetector/TemplateComponentDetector.php

@@ -2,6 +2,8 @@
 
 namespace Yireo\ExtensionChecker\ComponentDetector;
 
+use Magento\Framework\Exception\FileSystemException;
+use Magento\Framework\Exception\NotFoundException;
 use Yireo\ExtensionChecker\Component\Component;
 use Yireo\ExtensionChecker\File\FileCollectorInterface;
 use Yireo\ExtensionChecker\Util\ModuleInfo;
@@ -29,6 +31,8 @@ public function __construct(
     /**
      * @param string $moduleName
      * @return Component[]
+     * @throws FileSystemException
+     * @throws NotFoundException
      */
     public function getComponentsByModuleName(string $moduleName): array
     {

Console/Command/InspectClassCommand.php

@@ -11,36 +11,29 @@
 
 namespace Yireo\ExtensionChecker\Console\Command;
 
-use InvalidArgumentException;
-use Magento\Framework\Serialize\SerializerInterface;
 use ReflectionException;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface as Input;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface as Output;
 use Yireo\ExtensionChecker\PhpClass\ClassInspector;
 
 class InspectClassCommand extends Command
 {
-    private SerializerInterface $serializer;
     private ClassInspector $classInspector;
 
     /**
      * DeleteRuleCommand constructor.
      *
-     * @param SerializerInterface $serializer
-     * @param ModuleCollector $moduleCollector
+     * @param ClassInspector $classInspector
      * @param null $name
      */
     public function __construct(
-        SerializerInterface $serializer,
         ClassInspector $classInspector,
         $name = null
     ) {
         parent::__construct($name);
-        $this->serializer = $serializer;
         $this->classInspector = $classInspector;
     }
 

File/FileCollector.php

@@ -2,6 +2,8 @@
 
 namespace Yireo\ExtensionChecker\File;
 
+use Magento\Framework\Exception\FileSystemException;
+use Magento\Framework\Exception\ValidatorException;
 use Magento\Framework\Filesystem\Directory\ReadFactory as DirectoryReadFactory;
 use Symfony\Component\Finder\FinderFactory;
 use Yireo\ExtensionChecker\Exception\NoFilesFoundException;
@@ -33,9 +35,10 @@ public function __construct(
     }
 
     /**
-     * @param string $folder
+     * @param string $moduleFolder
      * @return array
-     * @throws NoFilesFoundException
+     * @throws FileSystemException
+     * @throws ValidatorException
      */
     public function getFilesFromModuleFolder(string $moduleFolder): array
     {

PhpClass/ClassInspector.php

@@ -7,6 +7,7 @@
 use Magento\Framework\ObjectManager\ConfigInterface;
 use ReflectionClass;
 use ReflectionException;
+use ReflectionNamedType;
 use Throwable;
 use Yireo\ExtensionChecker\Component\Component;
 use Yireo\ExtensionChecker\Component\ComponentFactory;
@@ -137,7 +138,12 @@ public function getDependenciesFromConstructor(): array
                 continue;
             }
 
-            $dependency = $this->normalizeClassName($parameter->getType()->getName());
+            $parameterType = $parameter->getType();
+            if (false === $parameterType instanceof ReflectionNamedType) {
+                continue;
+            }
+
+            $dependency = $this->normalizeClassName($parameterType->getName());
             if (!$this->isClassExists($dependency)) {
                 continue;
             }
@@ -150,7 +156,7 @@ public function getDependenciesFromConstructor(): array
                 continue;
             }
 
-            $dependencies[] = $this->normalizeClassName($parameter->getType()->getName());
+            $dependencies[] = $this->normalizeClassName($parameterType->getName());
         }
 
         return $dependencies;