Implement PR 60 from @gwharton

Author: jissereitsma

CHANGELOG.md

@@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.5.9] - 05 June 2025
+### Fixed
+- Add option to skip license validation in composer.json #62 @iranimij
+- Remove `Composer\Console\Input\InputArgument` #61 @frqnck
+- Add $moduleName to output messages where not currently implemented #60 @gwharton
+
 ## [2.5.8] - 02 June 2025
 ### Fixed
 - Suggest composer output CLI based on current composer.json

Console/Command/ScanCommand.php

@@ -184,7 +184,7 @@ private function outputTable(OutputInterface $output, array $messages = []): int
             'Message',
             'Group',
             'Suggestion',
-            'module'
+            'Module'
         ]);
 
         foreach ($messages as $message) {

Scan/ScanComposerRequirements.php

@@ -59,6 +59,7 @@ public function scan(string $moduleName, array $components)
     /**
      * @param Component $component
      * @param array $requirements
+     * @param string $moduleName
      * @return void
      */
     private function scanComponentWithComposerRequirements(
@@ -78,19 +79,26 @@ private function scanComponentWithComposerRequirements(
             return;
         }
 
-        $packageName = !empty($component->getPackageName()) ? $component->getPackageName() : $component->getComponentName();
+        $packageName = !empty($component->getPackageName()) ? $component->getPackageName(
+        ) : $component->getComponentName();
 
         $version = $component->getPackageVersion();
-        $message = 'No composer dependency found for "' . $packageName . '"';
+        $message = 'No composer dependency found for "'.$packageName.'"';
         $suggestion = sprintf('Current version is %s. ', $version);
         if ($this->composerProvider->shouldSuggestVersion($packageName)) {
             $suggestion .= sprintf('Perhaps use %s?', $this->composerProvider->getSuggestedVersion($version));
         }
 
-        $this->messageBucket->add($message, MessageGroupLabels::GROUP_MISSING_COMPOSER_DEP, $suggestion, $moduleName);
+        $this->messageBucket->add(
+            $message,
+            MessageGroupLabels::GROUP_MISSING_COMPOSER_DEP,
+            $suggestion,
+            $moduleName
+        );
     }
 
     /**
+     * @param string $moduleName
      * @param string $requirement
      * @param string $requirementVersion
      * @param Component[] $components
@@ -103,17 +111,21 @@ private function scanComposerRequirementWithComponents(
         array $components
     ) {
         $this->checkIfRequirementIsNeeded($moduleName, $requirement, $components);
-        $this->checkIfComposerRequirementUsesWildCard($requirement, $requirementVersion);
-        $this->checkPhpVersion($requirement, $requirementVersion);
+        $this->checkIfComposerRequirementUsesWildCard($moduleName, $requirement, $requirementVersion);
+        $this->checkPhpVersion($moduleName, $requirement, $requirementVersion);
     }
 
     /**
+     * @param string $moduleName
      * @param string $requirement
      * @param array $components
      * @return void
      */
-    private function checkIfRequirementIsNeeded(string $moduleName, string $requirement, array $components)
-    {
+    private function checkIfRequirementIsNeeded(
+        string $moduleName,
+        string $requirement,
+        array $components
+    ) {
         if ($this->runtimeConfig->isHideNeedless()) {
             return;
         }
@@ -130,12 +142,21 @@ private function checkIfRequirementIsNeeded(string $moduleName, string $requirem
             return;
         }
 
-        $message = 'Composer requirement "' . $requirement . '" possibly not needed';
+        $message = 'Composer requirement "'.$requirement.'" possibly not needed';
         $this->messageBucket->add($message, MessageGroupLabels::GROUP_UNNECESSARY_COMPOSER_DEP);
     }
 
-    private function checkIfComposerRequirementUsesWildCard(string $requirement, string $requirementVersion)
-    {
+    /**
+     * @param string $moduleName
+     * @param string $requirement
+     * @param string $requirementVersion
+     * @return void
+     */
+    private function checkIfComposerRequirementUsesWildCard(
+        string $moduleName,
+        string $requirement,
+        string $requirementVersion
+    ) {
         if (preg_match('/^ext-/', $requirement)) {
             return;
         }
@@ -145,22 +166,31 @@ private function checkIfComposerRequirementUsesWildCard(string $requirement, str
         }
 
         $version = $this->composerProvider->getVersionByComposerName($requirement);
-        $message = 'Composer requirement "' . $requirement . '" set to wildcard version';
+        $message = 'Composer requirement "'.$requirement.'" set to wildcard version';
         $suggestion = 'Current version is set to *. ';
         if ($this->composerProvider->shouldSuggestVersion($requirement)) {
             $suggestion .= sprintf('Perhaps use %s?', $this->composerProvider->getSuggestedVersion($version));
         }
 
-        $this->messageBucket->add($message, MessageGroupLabels::GROUP_WILDCARD_VERSION, $suggestion);
+        $this->messageBucket->add(
+            $message,
+            MessageGroupLabels::GROUP_WILDCARD_VERSION,
+            $suggestion,
+            $moduleName
+        );
     }
 
     /**
+     * @param string $moduleName
      * @param string $requirement
      * @param string $requirementVersion
      * @return void
      */
-    private function checkPhpVersion(string $requirement, string $requirementVersion)
-    {
+    private function checkPhpVersion(
+        string $moduleName,
+        string $requirement,
+        string $requirementVersion
+    ) {
         if ($requirement !== 'php') {
             return;
         }
@@ -170,8 +200,13 @@ private function checkPhpVersion(string $requirement, string $requirementVersion
             return;
         }
 
-        $message = 'Required PHP version "' . $requirementVersion . '" does not match your current PHP version ' . $currentVersion;
-        $this->messageBucket->add($message, MessageGroupLabels::GROUP_UNMET_REQUIREMENT);
+        $message = 'Required PHP version "'.$requirementVersion.'" does not match your current PHP version '.$currentVersion;
+        $this->messageBucket->add(
+            $message,
+            MessageGroupLabels::GROUP_UNMET_REQUIREMENT,
+            '',
+            $moduleName
+        );
     }
 
     /**

composer.json

@@ -2,7 +2,7 @@
   "name": "yireo/magento2-extensionchecker",
   "license": "OSL-3.0",
   "type": "magento2-module",
-  "version": "2.5.8",
+  "version": "2.5.9",
   "homepage": "https://github.com/yireo/Yireo_ExtensionChecker",
   "description": "Scan the code of a Magento module",
   "keywords": [