Ignore remove statements in XML files

[norgeindian]

It's amazing, that XML files are now also checked for dependencies.
Nevertheless, I would say, that a statement like the following would not break anything, if the original module / file does not exist:

<remove src="Vendor_Module::css/module.css"/>

This currently leads to needed dependency on this module and could be removed in my eyes.

[jissereitsma]

Good point. This actually opens up for a wider discussion. For instance, if a file etc/adminhtml/system.xml is there, it would a suggest a dependency with Magento_Backend. But if, in some parallel universe, that backend would not be there, the file would simply not be picked up upon. Likewise with XML layout for a specific handle: If the responsible module is not there, the handle is never activated.

I actually am not sure how we should deal with this. Any idea? Also cc @sprankhub

[sprankhub]

in some parallel universe

I think this is the main point here :) I'd argue that it is a valid, real-life use case to remove resources from modules that might not be installed (as shown in the issue). However, having the backend removed from Magento is just not very realistic. IMHO, it really depends on the concrete case.

Actually, the Hyvä detection could also be discussed:

Yireo_ExtensionChecker/ComponentCollector/LayoutComponentCollector.php

Line 30 in 01051ac

$patterns = ['hyva_modal' => 'Hyva_Theme'];

It might be that hyva_modal is used for Hyvä themes, but for Luma-based themes, the module still works without it 🤔 I am fine with keeping it for now. If we encounter more such cases, it might be an idea to have two different types: "missing dependency" (error) and "possible missing dependency" / "suggested dependency" (warning).