Do Not Ignore Test Folder

[sprankhub]

You currently ignore all files / classes in the Test folder:

Yireo_ExtensionChecker/Scan/FileCollector.php

Lines 45 to 47 in 07890ad

	if (strstr($file->getPath(), '/Test/')) {
	continue;
	}

Why? Wouldn't it be best practice to add dependencies from there to the require-dev section (if they are not already in the require section)?

[jissereitsma]

I think you are right. I'm not sure why I made this conclusion anymore. Version 1.0.2 fixes this.

[sprankhub]

Thanks @jissereitsma! Should we keep this open and also implement a require vs require-dev (if dependency is only used in Test directory) separation? Or don't you want to implement that separation? Or should it go into another issue? :)

[jissereitsma]

Unfortunately, this caused numerous issues. I have re-added the thing again and will re-open this issue as well. The ExtensionChecker sometimes bumps into classes that throw a PHP Fatal Error because they can't be instantiated by the ObjectManager - for instance, because they don't exist, or the code is broken, or something. I need to find a way to prevent those PHP Fatal Errors from happening in the first place.

[jissereitsma]

Hmm, release 1.1.0 fixes now many issues thanks to proper usage of the ObjectManager. Still, files within a Test folder that make use of classes from the TestFramework make use of a different composer autoloader, hence this still leads to errors.

[sprankhub]

Thanks! Not sure how to handle this, because I do not know the details tbh.

I just would like to propose the require vs require-dev separation again :-)