Fix possible issue with non-existing getProduct() method

jissereitsma · jissereitsma · commit 33dc53162d92 · 2025-02-19T13:48:40.000+01:00
diff --git a/DataLayer/Mapper/ProductDataMapper.php b/DataLayer/Mapper/ProductDataMapper.php
@@ -83,8 +83,10 @@ public function mapByProduct(ProductInterface $product): array
         }
 
         $productData['price'] = $this->priceFormatter->format((float) $product->getPriceInfo()->getPrice(FinalPrice::PRICE_CODE)->getValue());
-        if ($product->getCustomOption('simple_product') && $product->getCustomOption('simple_product')->getProduct()) {
-            $simpleProduct = $product->getCustomOption('simple_product')->getProduct();
+
+        $simpleProductOption = $product->getCustomOption('simple_product');
+        if ($simpleProductOption && method_exists($simpleProductOption, 'getProduct') && $simpleProductOption->getProduct()) {
+            $simpleProduct = $simpleProductOption->getProduct();
             $productData['price'] = $this->priceFormatter->format((float) $simpleProduct->getPriceInfo()->getPrice(FinalPrice::PRICE_CODE)->getValue());
         }
 

Original file line number	Diff line number	Diff line change
`@@ -83,8 +83,10 @@ public function mapByProduct(ProductInterface $product): array`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`$productData['price'] = $this->priceFormatter->format((float) $product->getPriceInfo()->getPrice(FinalPrice::PRICE_CODE)->getValue());`
`86`		`- if ($product->getCustomOption('simple_product') && $product->getCustomOption('simple_product')->getProduct()) {`
`87`		`- $simpleProduct = $product->getCustomOption('simple_product')->getProduct();`
	`86`	`+`
	`87`	`+ $simpleProductOption = $product->getCustomOption('simple_product');`
	`88`	`+ if ($simpleProductOption && method_exists($simpleProductOption, 'getProduct') && $simpleProductOption->getProduct()) {`
	`89`	`+ $simpleProduct = $simpleProductOption->getProduct();`
`88`	`90`	`$productData['price'] = $this->priceFormatter->format((float) $simpleProduct->getPriceInfo()->getPrice(FinalPrice::PRICE_CODE)->getValue());`
`89`	`91`	`}`
`90`	`92`