Merge branch 'master' of github.com:yireo/Yireo_GoogleTagManager2

Author: jissereitsma

.module.ini

@@ -2,3 +2,4 @@ EXTENSION_VENDOR="Yireo"
 EXTENSION_NAME="GoogleTagManager2"
 COMPOSER_NAME="yireo/magento2-googletagmanager2"
 PHP_VERSIONS=("7.4", "8.1", "8.2", "8.3")
+PHPSTAN_LEVEL=2

CHANGELOG.md

@@ -6,9 +6,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [3.9.16] - 17 March 2025
+## [3.9.17] - 17 March 2025
 ### Fixed
 - Issue with js minify, script not loaded #269 @taoufiqaitali
+- Fix type error when event name is empty #259
+
+## [3.9.16] - 19 February 2025
+### Fixed
+- Make sure to apply Container URL to IFRAME URL as well #267 @rikwillems
 
 ## [3.9.15] - 6 January 2025
 ### Fixed

DataLayer/Mapper/ProductDataMapper.php

@@ -83,8 +83,10 @@ public function mapByProduct(ProductInterface $product): array
         }
 
         $productData['price'] = $this->priceFormatter->format((float) $product->getPriceInfo()->getPrice(FinalPrice::PRICE_CODE)->getValue());
-        if ($product->getCustomOption('simple_product') && $product->getCustomOption('simple_product')->getProduct()) {
-            $simpleProduct = $product->getCustomOption('simple_product')->getProduct();
+
+        $simpleProductOption = $product->getCustomOption('simple_product');
+        if ($simpleProductOption && method_exists($simpleProductOption, 'getProduct') && $simpleProductOption->getProduct()) {
+            $simpleProduct = $simpleProductOption->getProduct();
             $productData['price'] = $this->priceFormatter->format((float) $simpleProduct->getPriceInfo()->getPrice(FinalPrice::PRICE_CODE)->getValue());
         }
 

FAQ.md

@@ -8,6 +8,15 @@ First of all, make sure to upgrade to the latest version of this extension, befo
 
 When making use of Server-Side Tracking, make sure to customize the setting **Orders states for purchase event** (`order_states_for_purchase_event`) and to manually trigger the `purchase` event where needed.
 
+# The purchase event is fired when the order hasn't been completed yet
+The Yireo GoogleTagManager extension uses the core event `sales_order_place_after` to trigger the `purchase` event. And this event is passed on from the server-side (PHP) towards the client-side (JavaScript) whenever a page is hit again (for instance, the loading of the checkout success page) or whenever an AJAX call occurs. At this moment, it might be that the payment has not yet occurred, so that the order status is not yet complete, but still the `purchase` event is triggered. This is **not** a bug, this is where you step in as an integrator of this Yireo GoogleTagManager2 extension and your custom choice of PSPs.
+
+How do you want this to work? Firing the `purchase` event on the success page will often **not** work either: It could be that a payment is delayed, so that the PSP only notifies the Magento application of the payment (so that the order can be completed) *after* the customer has left the shop. A similar scenario pops up when you are placing an order in the Magento Admin Panel. In these scenarios, there no longer is a scenario where client-side tracking (via JavaScript in the frontend) can be used. Instead, the solution is server-side tracking.
+
+The Yireo GoogleTagManager2 extension does not offer server-side tracking as a functionality, but it does support it. Simply enable the setting **Server-Side Tracking**, configure the **Container URL** and select which order states should trigger the `purchase` event (most likely only the `complete` status).
+
+If you need any additional help, the company of [Yireo](https://www.yireo.com/) is happy to help out with a custom (paid) consult as well.
+
 # Does this extension work under PHP 8.2?
 Yes, version 3 does. Version 2 is no longer maintained, but you could use the following composer patch with `vaimo/composer-patches`:
 ```bash

Test/Integration/DataLayer/Event/ViewCartTest.php

@@ -38,7 +38,7 @@ public function testValidViewCartEvent()
         $checkoutSession = ObjectManager::getInstance()->get(Session::class);
         $checkoutSession->setQuoteId($cartId);
         $checkoutSession->getQuote()->collectTotals();
-        $checkoutSession->getQuote()->save();
+        $quoteRepository->save($checkoutSession->getQuote());
 
         $cartRepository = ObjectManager::getInstance()->get(CartRepositoryInterface::class);
         $cart = $cartRepository->get($cartId);

composer.json

@@ -1,6 +1,6 @@
 {
     "name": "yireo/magento2-googletagmanager2",
-    "version": "3.9.16",
+    "version": "3.9.17",
     "license": "OSL-3.0",
     "type": "magento2-module",
     "homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2",

view/frontend/templates/iframe.phtml

@@ -7,4 +7,4 @@ use Yireo\GoogleTagManager2\Config\Config;
 /** @var Template $block */
 $config = $block->getConfig();
 ?>
-<noscript><iframe src="https://www.googletagmanager.com/ns.html?id=<?= $config->getId() ?>" height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>
+<noscript><iframe src="<?= $config->getGoogleTagmanagerUrl() ?>/ns.html?id=<?= $config->getId() ?>" height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>

view/frontend/templates/script.phtml

@@ -34,11 +34,11 @@ $events = ($config->waitForUserInteraction() === false)
                 f.parentNode.insertBefore(j, f);
             })(window, document, 'script', 'dataLayer', '<?= $gtmId ?>');
             <?php endforeach; ?>
-        }
+        };
 
         events.forEach(function (eventType) {
             window.addEventListener(eventType, initYireoGoogleTagManager2, {once: true, passive: true})
-        })
+        });
     })([<?= $events ?>]);
 
     <?php if ($config->isDebug()): ?>