Release

jissereitsma · jissereitsma · commit 6c888c310b87 · 2024-10-22T14:07:21.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,9 +5,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+
+## [3.9.10] - 22 October 2024
 ### Fixed
 - Only trigger `view_cart` event when there are items in the cart
 - Allow multiple GTM IDs
+- Fix GTM URL
 
 ## [3.9.9] - 22 October 2024
 ### Fixed
diff --git a/Config/Config.php b/Config/Config.php
@@ -209,13 +209,14 @@ public function hasServerSideTracking(): bool
      */
     public function getGoogleTagmanagerUrl(): string
     {
+        $default = 'https://www.googletagmanager.com';
         if (false === $this->hasServerSideTracking()) {
-            return '';
+            return $default;
         }
 
         return $this->getModuleConfigValue(
             'serverside_gtm_url',
-            'https://www.googletagmanager.com'
+            $default
         );
     }
 
diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
   "name": "yireo/magento2-googletagmanager2",
-  "version": "3.9.9",
+  "version": "3.9.10",
   "license": "OSL-3.0",
   "type": "magento2-module",
   "homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2",

Original file line number	Diff line number	Diff line change
`@@ -209,13 +209,14 @@ public function hasServerSideTracking(): bool`
`209`	`209`	`*/`
`210`	`210`	`public function getGoogleTagmanagerUrl(): string`
`211`	`211`	`{`
	`212`	`+ $default = 'https://www.googletagmanager.com';`
`212`	`213`	`if (false === $this->hasServerSideTracking()) {`
`213`		`- return '';`
	`214`	`+ return $default;`
`214`	`215`	`}`
`215`	`216`
`216`	`217`	`return $this->getModuleConfigValue(`
`217`	`218`	`'serverside_gtm_url',`
`218`		`- 'https://www.googletagmanager.com'`
	`219`	`+ $default`
`219`	`220`	`);`
`220`	`221`	`}`
`221`	`222`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "yireo/magento2-googletagmanager2",`
`3`		`- "version": "3.9.9",`
	`3`	`+ "version": "3.9.10",`
`4`	`4`	`"license": "OSL-3.0",`
`5`	`5`	`"type": "magento2-module",`
`6`	`6`	`"homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2",`