add_shipping_info and add_payment_info events not triggered with Hyvä Checkout auto-select

[Ylmzef]

Hello,

I’m using Hyvä Checkout together with this extension and noticed that some GA4 events are not firing.

Steps to reproduce

1. Install yireo/magento2-googletagmanager2

2. Install yireo/magento2-googletagmanager2-hyva-checkout

3. In Hyvä Checkout settings enable:

   • Enable first available payment method automatically
   • Enable first available shipping method automatically

4. Go through checkout.

Expected result

• add_shipping_info should be triggered when the shipping method is auto-selected.
• add_payment_info should be triggered when the payment method is auto-selected.

Actual result

• Only begin_checkout event is triggered.
• add_shipping_info and add_payment_info events are not fired when the first available methods are applied automatically.

Notes

• When customers manually select a shipping or payment method, the events do fire.
• Issue only occurs when using the auto-selection feature of Hyvä Checkout.

Could you please check if the auto-selection should trigger these events, or if additional integration is needed?

Thanks in advance!

[samicoman]

The patch below fixes it, but I don't have the time at the moment to create a PR. cc @jissereitsma

Index: view/frontend/layout/hyva_checkout_index_index.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/view/frontend/layout/hyva_checkout_index_index.xml b/view/frontend/layout/hyva_checkout_index_index.xml
--- a/view/frontend/layout/hyva_checkout_index_index.xml
+++ b/view/frontend/layout/hyva_checkout_index_index.xml
@@ -10,6 +10,9 @@
                 <arguments>
                     <argument name="magewire" xsi:type="object">Yireo\GoogleTagManager2HyvaCheckout\MageWire\Checkout</argument>
                     <argument name="begin_checkout_event" xsi:type="object">Yireo\GoogleTagManager2\DataLayer\Event\BeginCheckout</argument>
+                    <argument name="add_shipping_info_checkout_event" xsi:type="object">Yireo\GoogleTagManager2\DataLayer\Event\AddShippingInfo</argument>
+                    <argument name="add_payment_info_checkout_event" xsi:type="object">Yireo\GoogleTagManager2\DataLayer\Event\AddPaymentInfo</argument>
+                    <argument name="view_model" xsi:type="object">Yireo\GoogleTagManager2HyvaCheckout\ViewModel\DataLayer</argument>
                 </arguments>
             </block>
         </referenceContainer>
Index: view/frontend/templates/data-layer.phtml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/view/frontend/templates/data-layer.phtml b/view/frontend/templates/data-layer.phtml
--- a/view/frontend/templates/data-layer.phtml
+++ b/view/frontend/templates/data-layer.phtml
@@ -4,13 +4,13 @@
 /** @version 1.0.2 */

 use Magento\Framework\View\Element\Template;
-use Yireo\GoogleTagManager2\DataLayer\Event\BeginCheckout as BeginCheckoutEvent;
 use Yireo\GoogleTagManager2HyvaCheckout\MageWire\Checkout as CheckoutComponent;
+use Yireo\GoogleTagManager2HyvaCheckout\ViewModel\DataLayer as ViewModel;

 /** @var Template $block */
-/** @var BeginCheckoutEvent $beginCheckoutEvent */
+/** @var ViewModel $viewModel */
 /** @var CheckoutComponent $magewire */
-$beginCheckoutEvent = $block->getData('begin_checkout_event');
+$viewModel = $block->getData('view_model');
 ?>
 <div class="hidden">
     <script>
@@ -19,7 +19,15 @@
         });

         (function () {
-            yireoGoogleTagManager2Pusher(<?= /* @noEscape */ json_encode($beginCheckoutEvent->get()) ?>, 'Hyva Checkout');
+            yireoGoogleTagManager2Pusher(<?= /* @noEscape */ $viewModel->getBeginCheckoutEvent() ?>, 'Hyva Checkout');
+
+            <?php if ($viewModel->shouldPushAddShippingInfoEvent()): ?>
+                yireoGoogleTagManager2Pusher(<?= /* @noEscape */ $viewModel->getAddShippingInfoEvent() ?>, 'Hyva Checkout');
+            <?php endif; ?>
+
+            <?php if ($viewModel->shouldPushAddPaymentInfoEvent()): ?>
+                yireoGoogleTagManager2Pusher(<?= /* @noEscape */ $viewModel->getAddPaymentInfoEvent() ?>, 'Hyva Checkout');
+            <?php endif; ?>
         })();
     </script>
 </div>
Index: ViewModel/DataLayer.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/ViewModel/DataLayer.php b/ViewModel/DataLayer.php
new file mode 100644
--- /dev/null
+++ b/ViewModel/DataLayer.php
@@ -0,0 +1,54 @@
+<?php
+declare(strict_types=1);
+
+namespace Yireo\GoogleTagManager2HyvaCheckout\ViewModel;
+
+use Hyva\Checkout\Model\ConfigData\HyvaThemes\SystemConfigExperimental;
+use Magento\Checkout\Model\Session as CheckoutSession;
+use Magento\Framework\Serialize\Serializer\Json;
+use Magento\Framework\View\Element\Block\ArgumentInterface;
+use Yireo\GoogleTagManager2\DataLayer\Event\AddPaymentInfo;
+use Yireo\GoogleTagManager2\DataLayer\Event\AddShippingInfo;
+use Yireo\GoogleTagManager2\DataLayer\Event\BeginCheckout;
+
+class DataLayer implements ArgumentInterface
+{
+    public function __construct(
+        private readonly CheckoutSession $checkoutSession,
+        private readonly BeginCheckout $beginCheckout,
+        private readonly AddShippingInfo $addShippingInfo,
+        private readonly AddPaymentInfo $addPaymentInfo,
+        private readonly SystemConfigExperimental $systemConfigExperimental,
+        private readonly Json $json,
+    ) {
+    }
+
+    public function getBeginCheckoutEvent(): bool|string
+    {
+        return $this->json->serialize($this->beginCheckout->get());
+    }
+
+    public function getAddShippingInfoEvent(): bool|string
+    {
+        return $this->json->serialize($this->addShippingInfo->get());
+    }
+
+    public function getAddPaymentInfoEvent(): bool|string
+    {
+        $this->addPaymentInfo->setCartId((int) $this->checkoutSession->getQuote()->getId());
+        $this->addPaymentInfo->setPaymentMethod((string) $this->checkoutSession->getQuote()->getPayment()->getMethod());
+        return $this->json->serialize($this->addPaymentInfo->get());
+    }
+
+    public function shouldPushAddShippingInfoEvent(): bool
+    {
+        return $this->systemConfigExperimental->enableFirstAvailableShippingMethod()
+            && $this->checkoutSession->getQuote()->getShippingAddress()->getShippingMethod();
+    }
+
+    public function shouldPushAddPaymentInfoEvent(): bool
+    {
+        return $this->systemConfigExperimental->enableFirstAvailablePaymentMethod()
+            && $this->checkoutSession->getQuote()->getPayment()->getMethod();
+    }
+}