item_variant missing on add to cart of configurable product

[luukfiets]

Hi @jissereitsma,

We're using the Yireo module for one of our clients and I've noticed that the item_variant parameter is missing on the add_to_cart event even though it's mentioned in the code (here). Example of the add to cart event:

Also, I've noticed that the item_id in the add_to_cart event for a configurable product is the SKU of the child product instead of the parent / configurable itself. Usually it's recommended to use the parent SKU in the item_id as that's the consistent one. The item_variant is only available for some specific events like add_to_cart and in the checkout events as only then you know the exact variant that was chosen. In those cases, you want item_id to always be the parent ID and item_variant to contain the variant SKU.

I'm not a Magento developer myself, but if there is anything I can do to help you with this, please let me know.

[jissereitsma]

Actually, this sparked discussions in the past. At this moment, refactoring this is only possible if both scenarios are kept alive - and as of yet, I'm getting no reports to do this, other than this. I'll keep this open in the hope that somebody adds a PR for this.

[luukfiets]

@jissereitsma, other modules usually have an option that allow you to set which value should be used in the item_id parameter. If you could add such an option, you could default it to the current state (variant ID if available) to allow for backward compatibility. If a user wants the item_id to be populated by the parent SKU / ID and then have the item_variant contain the simple SKU / ID, they can do so by manually selecting the other option in the newly created setting for this.