Is there a specific reason for only loading product EAV attributes that are visible on frontend?

[junioradwise]

In vendor/yireo/magento2-googletagmanager2/Config/Source/ProductAttributes.php:36 the following code is used:

$this->searchCriteriaBuilder->addFilter('is_visible_on_front', 1);

This means that only EAV attributes that are visible on frontend are rendered and able to be used to push to dataLayer. Is this on purpose as in our case we would like to push attributes that are not displayed on the frontent.

[jissereitsma]

Yes, this is on purpose. The only alternative is to actually display all product EAV attributes, but that will cause more harm than good: Some shops add specific meta-data for internal usage only, and suddenly that would end up in GA.

Because of your request, the next version will include new constructor arguments that you can change using a DI type so that you can "remove" that line: 649944d

[junioradwise]

Thank you for your fast reply. Personally I don't see why it would suddenly end up in GA because one should add it in this list first before it is pushed to dataLayer but I understand the decision. Thank you for your improvement so that we can easily change the behavior.