Category performance

[rhoerr]

Issue

I was profiling category performance on a client site via New Relic, and found Yireo_GoogleTagManager2 adding 100-150 ms to the response time with a category page size of 20. 4-8ms per product shown.

Context

For this site, product list view info is not super important, so that performance hit on every uncached category request isn't worth it.

I cut it down for now by setting the "Maximum Products in Category" setting to 1, so it only processes the top product.
I considered disabling \Yireo\GoogleTagManager2\DataLayer\Tag\Category\Products entirely.

I think most of the delay is from loading category info for each product. There's no easy way to change that with a plugin either, because getProductCategory and attachCategoriesData are private methods.

Suggestion

It would be nice if:

1. The category handling was faster, or
2. The product list behavior and info was configurable, so we could turn off including product categories or the product view data entirely

---

Aside, it seemed like this catalog_category_view data layer handling does not extend to search results (catalogsearch_result_index), so I'm not clear how useful it is in the first place.

Thanks

[jissereitsma]

Could you mention which PHP version and which version of the Yireo GoogleTagManager2 module are used?

I noticed a typo in the Products class which caused a product to be set as property of a product, as if that product was a category. In the end, this might have well caused the issue that you are seeing: 27bd8f3

I'm releasing a new version right away to fix this. It would be good to profile things after upgrading again.

[jissereitsma]

Fixed in version is 3.10.4

[rhoerr]

Thanks, I'll give that a try when time allows.

The analysis was with:
GTM2 = 3.10.2
PHP = 8.1