Skip to content

equalYTextPText does not compare mark names, only attributes #197

@aonnikov

Description

@aonnikov

Describe the bug
sync-plugin does not detect changes when mark changed. Based on what I see in code, I assume that the problem is in equalYTextPText function, it compares attributes, but does not actually check mark types.

To Reproduce

  1. Type some text and mark it with bold
  2. Change mark to code. I'm using tiptap, so I run toggleCode command that unsets bold mark and sets code mark.
  3. The change won't be applied to the ydoc/not sent to the server

Expected behavior
The plugin is to able to recognize mark change.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions