no diagnostic found when clicking on "Open in new tab"

[bennycode]

Describe the bug

I clicked "Open in new tab" and received this:

Expected behavior

A sidebar with error explanation.

Original error

Argument of type '{ intervalInMillis: number; }' is not assignable to parameter of type 'ExchangeCandleImportRequest'.
Type '{ intervalInMillis: number; }' is missing the following properties from type 'ExchangeCandleImportRequest': startTimeFirstCandle, startTimeLastCandle

Code

import {ms, CurrencyPair, getAlpacaClient} from '@typedtrader/exchange';

// Request: SHOP,USD 1h
export default async (request: string) => {
  if (!process.env.ALPACA_LIVE_API_KEY) {
    return;
  }

  if (!process.env.ALPACA_LIVE_API_SECRET) {
    return;
  }

  const spaceIndex = request.indexOf(' ');
  const pairPart = request.slice(0, spaceIndex);
  const commaIndex = pairPart.indexOf(',');
  const base = pairPart.slice(0, commaIndex);
  const counter = pairPart.slice(commaIndex + 1);
  const pair = new CurrencyPair(base, counter);
  const interval = request.slice(spaceIndex + 1);
  const intervalInMillis = ms(interval);

  const client = getAlpacaClient({
    apiKey: process.env.ALPACA_LIVE_API_KEY,
    apiSecret: process.env.ALPACA_LIVE_API_SECRET,
    usePaperTrading: false,
  });

  const candle = await client.getCandles(pair, {
    intervalInMillis,
  });

  return JSON.stringify({pair, interval, intervalInMillis});
};

Screenshots

[kevinramharak]

Based on the message, the extension thinks the error starts on line 19 and ends at line 21
The source code has the error on line 28 and 30. So it is wrong by an offset of 9.
I will try and reproduce it.

[bennycode]

@kevinramharak thank you! Can I provide more debugging info for you? I also have the issue that sometimes the new tab doesn't even open when clicking on the button.

[kevinramharak]

@bennycode I cloned trading-signals to the add-alpaca branch, but I cannot reproduce it. I will try and play around with the debug version of the extension and see if it's a cache invalidation thing, because it seems like it.

As for more debug info, I don't think there is much implemented yet. If you can check the Toggle Developer Tools to see if there is an error logged:

There is one code path that ignores the new tab command if an invalid parameter is given, which should be logged. That should be the cause of the new tab not opening when clicking the button.

Also do you use Windows as OS? Just to check if its a path issue between Windows/Linux/MacOS, because we have had those before.

But this is a good reason to finish #151 because it would make these kind of bugs a lot easier to figure out.