atc: fix mode override to be read from annotation instead of label

Author: davidmdm

cmd/atc/main_test.go

@@ -1261,10 +1261,13 @@ func TestAirwayModes(t *testing.T) {
 	testBE, err := backendIntf.Get(ctx, "test", metav1.GetOptions{})
 	require.NoError(t, err)
 
-	labels := testBE.GetLabels()
-	labels[flight.AnnotationOverrideMode] = string(v1alpha1.AirwayModeDynamic)
+	annotations := testBE.GetAnnotations()
+	if annotations == nil {
+		annotations = map[string]string{}
+	}
+	annotations[flight.AnnotationOverrideMode] = string(v1alpha1.AirwayModeDynamic)
 
-	testBE.SetLabels(labels)
+	testBE.SetAnnotations(annotations)
 
 	_, err = backendIntf.Update(ctx, testBE, metav1.UpdateOptions{FieldManager: "test"})
 	require.NoError(t, err)

internal/atc/atc.go

@@ -503,11 +503,11 @@ func (atc atc) FlightReconciler(params FlightReconcilerParams) ctrl.HandleFunc {
 		}
 
 		overrideMode := func() v1alpha1.AirwayMode {
-			labels := resource.GetLabels()
-			if labels == nil {
+			annotations := resource.GetAnnotations()
+			if annotations == nil {
 				return ""
 			}
-			override := v1alpha1.AirwayMode(labels[flight.AnnotationOverrideMode])
+			override := v1alpha1.AirwayMode(annotations[flight.AnnotationOverrideMode])
 			if !slices.Contains(v1alpha1.Modes(), override) {
 				return ""
 			}